Repository navigation
Fix/ldap username enumeration - #103
Open
AugustoMagalhaes wants to merge 4 commits into
Open
AugustoMagalhaes wants to merge 4 commits into
AugustoMagalhaes wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LDAPAuthentifier.login()returned different errors depending on why authentication failed. A missing or ambiguous user surfaced the internal lookup message (e.g. "Unable to find user X in base ..."), a wrong password returned "Invalid user or password", and a locked/disabled account returned "LDAP server is unwilling to perform: ...". These observable differences in the response let a caller infer whether a given account exists (CWE-204, Observable Response Discrepancy).This change makes every credential failure return the same generic error, while keeping the specific reason in the server-side logs for diagnosis:
A dedicated
LDAPUserNotFoundError(subclass ofLDAPAuthenticationError) is introduced sologin()can distinguish the lookup failure and normalise it, without masking genuine operational errors (server unreachable, missing base DN, service bind failure), which keep their specific messages.Tests
Added regression tests ensuring a missing/ambiguous user and a locked account both return the generic error, and that the bind is never attempted when the user cannot be resolved. Existing lookup tests were tightened to assert the dedicated exception type.
Notes
Reported privately to the maintainer beforehand; opening the PR as requested.