Add Redis to the default Kubernetes Recipe Pack - #12754
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
Adds the Radius.Data/redisCaches Kubernetes Bicep recipe to the CLI-created default Recipe Pack installed by rad install kubernetes, aligning it with the existing Kubernetes defaults while preserving channel-aware tag resolution via resolveRecipeTag.
Changes:
- Extend
GetCoreTypesRecipeInfo()to includeRadius.Data/redisCachespointing atghcr.io/radius-project/kube-recipes/rediscaches:<tag>. - Update unit tests to expect the additional core-type recipe entry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/cli/recipepack/recipepack.go | Adds the Redis cache recipe to the default core-types recipe list using existing tag resolution logic. |
| pkg/cli/recipepack/recipepack_test.go | Updates expectations (count + resource type list) to include Radius.Data/redisCaches. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12754 +/- ##
=======================================
Coverage 59.81% 59.81%
=======================================
Files 776 776
Lines 46042 46045 +3
=======================================
+ Hits 27541 27544 +3
Misses 18501 18501 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
87f37b8 to
6f3be21
Compare
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
6f3be21 to
f25004a
Compare
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
Summary
Add the
Radius.Data/redisCachesKubernetes Bicep Recipe to the default Recipe Pack created byrad install kubernetes.Add a focused Core RP non-cloud E2E test that deploys Redis without an explicit Recipe and validates the Radius application/cache plus the Recipe-provisioned Kubernetes Deployment, running Pod, and Service.
Reason for change
This aligns the CLI-created default pack with the existing
Radius.Data/redisCachesentry in the resource-types-contrib Kubernetes default Recipe Pack. It uses the sameghcr.io/radius-project/kube-recipes/rediscachesOCI source while preserving the CLI's channel-aware tag resolution.The E2E test proves that a preview environment receiving the CLI-created default Recipe Pack can provision a running Redis cache. It intentionally has no consumer connection or managed-secret assertions, so it remains independent of the managed-secret connection behavior merged in radius#12709 and resource-types-contrib#300.
How to test
The targeted Redis E2E requires a Radius installation built from this branch so the install-time default pack contains Redis. The previous PR revision passed
Functional Tests - corerp-noncloud; the rebased revision reruns that job in PR CI.File change summary
pkg/cli/recipepack/recipepack.gopkg/cli/recipepack/recipepack_test.gotest/functional-portable/corerp/noncloud/resources/rediscache_test.gotest/functional-portable/corerp/noncloud/resources/testdata/corerp-resources-rediscache.biceptest/validation/shared.go