Skip to content

Add Redis to the default Kubernetes Recipe Pack - #12754

Merged
willdavsmith merged 3 commits into
mainfrom
willdavsmith-add-default-redis-recipe
Sep 1, 2026
Merged

Add Redis to the default Kubernetes Recipe Pack#12754
willdavsmith merged 3 commits into
mainfrom
willdavsmith-add-default-redis-recipe

Conversation

@willdavsmith

@willdavsmith willdavsmith commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Add the Radius.Data/redisCaches Kubernetes Bicep Recipe to the default Recipe Pack created by rad install kubernetes.

Add a focused Core RP non-cloud E2E test that deploys Redis without an explicit Recipe and validates the Radius application/cache plus the Recipe-provisioned Kubernetes Deployment, running Pod, and Service.

Reason for change

This aligns the CLI-created default pack with the existing Radius.Data/redisCaches entry in the resource-types-contrib Kubernetes default Recipe Pack. It uses the same ghcr.io/radius-project/kube-recipes/rediscaches OCI source while preserving the CLI's channel-aware tag resolution.

The E2E test proves that a preview environment receiving the CLI-created default Recipe Pack can provision a running Redis cache. It intentionally has no consumer connection or managed-secret assertions, so it remains independent of the managed-secret connection behavior merged in radius#12709 and resource-types-contrib#300.

How to test

go test ./pkg/cli/recipepack ./test/validation
go test ./test/functional-portable/corerp/noncloud/resources -run '^$'
$HOME/.rad/bin/bicep build test/functional-portable/corerp/noncloud/resources/testdata/corerp-resources-rediscache.bicep --stdout >/dev/null

The targeted Redis E2E requires a Radius installation built from this branch so the install-time default pack contains Redis. The previous PR revision passed Functional Tests - corerp-noncloud; the rebased revision reruns that job in PR CI.

File change summary

File Summary of change
pkg/cli/recipepack/recipepack.go Add the Redis cache Recipe definition to the CLI-created default pack.
pkg/cli/recipepack/recipepack_test.go Include Redis caches in the expected default Recipe definitions.
test/functional-portable/corerp/noncloud/resources/rediscache_test.go Add E2E coverage for provisioning Redis through the default Recipe Pack.
test/functional-portable/corerp/noncloud/resources/testdata/corerp-resources-rediscache.bicep Define an application and Redis cache with no explicit Recipe.
test/validation/shared.go Add the Radius.Data Redis cache validation resource type.

Copilot AI lite review requested due to automatic review settings August 20, 2026 21:22
@willdavsmith
willdavsmith requested review from a team as code owners August 20, 2026 21:22
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the Radius.Data/redisCaches Kubernetes Bicep recipe to the CLI-created default Recipe Pack installed by rad install kubernetes, aligning it with the existing Kubernetes defaults while preserving channel-aware tag resolution via resolveRecipeTag.

Changes:

  • Extend GetCoreTypesRecipeInfo() to include Radius.Data/redisCaches pointing at ghcr.io/radius-project/kube-recipes/rediscaches:<tag>.
  • Update unit tests to expect the additional core-type recipe entry.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/cli/recipepack/recipepack.go Adds the Redis cache recipe to the default core-types recipe list using existing tag resolution logic.
pkg/cli/recipepack/recipepack_test.go Updates expectations (count + resource type list) to include Radius.Data/redisCaches.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.81%. Comparing base (be6731f) to head (7936996).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12754   +/-   ##
=======================================
  Coverage   59.81%   59.81%           
=======================================
  Files         776      776           
  Lines       46042    46045    +3     
=======================================
+ Hits        27541    27544    +3     
  Misses      18501    18501           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

Unit Tests

    2 files  ±0    459 suites  ±0   8m 33s ⏱️ +2s
6 527 tests ±0  6 525 ✅ ±0  2 💤 ±0  0 ❌ ±0 
7 803 runs  ±0  7 801 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 7936996. ± Comparison against base commit be6731f.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

Functional Tests - upgrade-noncloud

3 tests  ±0   3 ✅ ±0   1m 37s ⏱️ +17s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit f25004a. ± Comparison against base commit 76eaaac.

♻️ This comment has been updated with latest results.

@willdavsmith
willdavsmith force-pushed the willdavsmith-add-default-redis-recipe branch 2 times, most recently from 87f37b8 to 6f3be21 Compare August 24, 2026 17:35

@brooke-hamilton brooke-hamilton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Ping me to re-approve after the conflicts are resolved. Also, merge from main or rebase to get the upgraded functional tests with fewer 503 errors.

Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
@radius-functional-tests

radius-functional-tests Bot commented Sep 1, 2026

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository radius-project/radius
Commit ref 7936996
Unique ID funcfb68560cf8
Image tag pr-funcfb68560cf8
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcfb68560cf8
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcfb68560cf8
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcfb68560cf8
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcfb68560cf8
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcfb68560cf8
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@willdavsmith
willdavsmith added this pull request to the merge queue Sep 1, 2026
Merged via the queue into main with commit 7f5d4d1 Sep 1, 2026
79 checks passed
@willdavsmith
willdavsmith deleted the willdavsmith-add-default-redis-recipe branch September 1, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants