Repository navigation
Conversation
QA fix verification: comp-t-7.group-qa-f4.1-qa (D1-F1) at dfdf4aaVerdict: PASS. 1 carried finding verified fixed.
req-qa, locked to D1-F1, confirmed ADR-0023 now gives one mapping for an invalid ref, step or bead id: Reviewer notes, not gating: line 227 still says the id newtypes use serde Disclosures: the filing checker is dev-sanity (sc-sanity-llm), not a QA reviewer, so I hand-dispatched req-qa as the document verifier. The reviewer read the worktree (HEAD equals the pinned commit) and did not run the code; shipped behaviour (FUZZ-021 / typed-parent-id fixes) was verified in their own QA rounds. CI not checked (rate-limit rule). |
QA fix verification: comp-t-7.group-qa-f4-qa (qa1-f4) at dfdf4aaVerdict: PASS. 1 carried finding verified fixed.
req-qa, locked to qa1-f4, verified both halves of the deliverable at the pinned content:
Reviewer notes, not gating: the relation-validation table (line 493) does not say an invalid id inside Disclosures: the reviewer read the worktree and could not run git (I confirmed the worktree HEAD equals the PR head dfdf4aa). Shipped behaviour was fixed by the FUZZ-021 and typed-parent-id fixes, verified in their own rounds. CI not checked (rate-limit rule). |
dfdf4aa to
cedd442
Compare
Fixes comp-t-7.group-qa-f4.1 (sanity finding on f4). This is the one sentence you authorized: a BeadId, GraphRef or StepId that fails its newtype rule returns GraphIdInvalid (exit 2), not RequestDeserializationFailed. That matches FUZZ-021 (#702) and #706. Rebased by the stack writer (44667de -> dfdf4aa).
🤖 Generated with Claude Code