Skip to content

fix(beads): preserve legacy registry formula names (FUZZ-013 r2) - #716

Merged
randlee merged 1 commit into
fix/t-7-qa-f4-1-adr-id-error-sentencefrom
fix/t-7-fuzz-013-r2-all-ops-names
Oct 8, 2026
Merged

randlee merged 1 commit into
fix/t-7-qa-f4-1-adr-id-error-sentencefrom
fix/t-7-fuzz-013-r2-all-ops-names

Conversation

@randlee

@randlee randlee commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Fixes comp-t-7.fuzz-013-r2-fix (round 2 of FUZZ-013, filed by comp-t-7.2-qa): validate, preview_pour and pour accept Phase R registry formula_name spellings again; graph-mode (attach/preview_attach) stays strict; empty name gives BEADS_FORMULA_NAME_REQUIRED.

Gates at 3603608: clippy -D warnings clean, fmt clean, cargo test --workspace 1063 passed / 0 failed / 0 ignored.

🤖 Generated with Claude Code

@randlee

randlee commented Oct 7, 2026

Copy link
Copy Markdown
Owner Author

QA fix verification: comp-t-7.fuzz-013-r2-qa (fuzz-013) at 3603608

Verdict: PASS. 1 carried finding verified fixed.

Finding Disposition
fuzz-013 fixed

Local fmt, clippy -D warnings and tests clean at this head. CI not checked (rate-limit rule). Dev-sanity passed at this head.

Round 2 of fuzz-013. Verified against the carried finding's acceptance criteria: legacy names ('re g0', accented, 'a+b', empty) no longer fail with BEADS_REQUEST_DESERIALIZATION_FAILED on render, validate, preview-pour and pour; pour and preview-pour with an empty name give BEADS_FORMULA_NAME_REQUIRED; preview-attach and attach stay strict; the FUZZ-013 test is un-ignored (17 passed in fuzz_regressions, 22 in contract) and fails at the round-1 commit 1266f41.

Observation, not a finding of this round: a wrong-typed formula_name (for example 5) is now silently dropped on render, validate, preview-pour and pour instead of failing deserialization (attach and preview-attach still reject it). Whether origin/develop rejected it could not be established (develop has no request.rs), and it is outside the carried finding's criteria, so it was not held against the fix. The verifier was asked about it by me; I reported it as an extra check. Recommend the lead decide whether to file a follow-up bead (strip only string-typed names, keep the original error for other types). The FUZZ-013 test covers only parse_request, not the CLI, the empty name or the wrong-type case.

Verification used a fake-bd stub (post-parse failures such as BEADS_WHERE_FAILED come from the stub).

@randlee
randlee force-pushed the fix/t-7-fuzz-013-r2-all-ops-names branch from 3603608 to 08da557 Compare October 8, 2026 00:25
@randlee
randlee removed this pull request from stack #625 October 8, 2026 00:45
@randlee
randlee added this pull request to stack #739 October 8, 2026 01:15
@randlee
randlee merged commit 19e4cb0 into integrate/phase-t Oct 8, 2026
11 of 15 checks passed
@randlee
randlee deleted the fix/t-7-fuzz-013-r2-all-ops-names branch October 8, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant