Conversation
This comment was marked as low quality.
This comment was marked as low quality.
Owner
Author
|
v1.0.0-alpha.1 has been released in NPM with the code from this branch |
- Bump package version from 0.45.0 to 1.0.0 in package.json - Rewrite the main module in ESM - Remove unnecessary binary and files entries in package.json
Owner
Author
|
I consider relicensing to CC0 with this release. Argon2 is frozen, Node interface is unlikely to change significantly, and the library is thin enough that I don't expect big changes other than bumping dependencies, so it would benefit from a public domain license. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all native bindings and prebuilt binary infrastructure, transitioning the package to use the native Argon2 implementation now available in
node:cryptostarting with Node.js 24.7.0. This simplifies the codebase and CI/CD workflows.node:crypto's Argon2, removing native bindings and related dependencies (bindings.gyp,.gitmodules+argon2submodule,.clang-format, etc)The package is now a thin wrapper around Node.js native Argon2 implementation, requiring Node.js 24.7.0 or newer. All legacy native code, build scripts, and related CI/CD complexity have been removed. It will continue working with prebuilt binaries in v0 at least until Node 22 is EOL, as explained in #469