Skip to content

Display uf2 combine --offset default-value in hexadecimal #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lurch wants to merge 2 commits into
base: develop
Choose a base branch
from
+2 −2
Open

Display uf2 combine --offset default-value in hexadecimal #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08cefdc
Display uf2 combine --offset default-value in hexadecimal
lurch Jul 27, 2026
5fede28
Also update README.md to match
lurch Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,7 +1067,7 @@ OPTIONS:
--offset
Offset second UF2 by amount
<offset>
offset amount (default to 0)
offset amount (default to 0x0)

@will-v-pi will-v-pi Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
offset amount (default to 0x0)
offset amount (hexadecimal, default to 0x0)

Partition options
--partition
Place second UF2 in partition (first UF2 must contain a partition table)
Expand Down
2 changes: 1 addition & 1 deletion main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1639,7 +1639,7 @@ struct uf2_combine_command : public cmd {
).force_expand_help(true) % "UF2 Family options" +
(
option("--offset").set(settings.uf2.offset_set) % "Offset second UF2 by amount" &
hex("offset").set(settings.uf2.offset) % "offset amount (default to 0)"
hex("offset").set(settings.uf2.offset) % "offset amount (default to 0x0)"

@will-v-pi will-v-pi Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth explicitly mentioning it is hexadecimal too?

Suggested change
hex("offset").set(settings.uf2.offset) % "offset amount (default to 0x0)"
hex("offset").set(settings.uf2.offset) % "offset amount (hexadecimal, default to 0x0)"

).force_expand_help(true) % "Offset options" +
(
option("--partition").set(settings.uf2.partition_set) % "Place second UF2 in partition (first UF2 must contain a partition table)" &
Expand Down
Loading