perf(access): read the token once instead of once per header step - #24
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rohilsurana
force-pushed
the
perf/decode-token-once
branch
from
September 16, 2026 08:10
14525f3 to
4deb146
Compare
AmanGIT07
approved these changes
Sep 16, 2026
rohilsurana
marked this pull request as ready for review
September 16, 2026 09:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #23, which has merged. Rebased onto main, so the diff here is just
this change.
append_claims_as_headersandverify_organization_id_headereach decoded thesame token, so a request that used both read it twice.
run()now decodes onceand passes the claims to both.
The decode still does not happen at all when nothing needs the claims.
verify_organization_id_headerused to read the org header itself and returnearly when it was missing, so
run()now reads it once and passes the valuedown to keep that.
Only the decode moved. Each function keeps its own handling of an unreadable
payload: the claim headers refuse the request, the org check drops the header.
Merging those into one guard would have turned the second into a 401.
Four cases count decodes through a wrapper around the real decoder. On the old
code the first one fails with
expected 1 got 2; the other three pass eitherway, because the double decode only happened when both steps ran and the client
actually sent the org header.
73 passed on Kong 3.4 and 3.9, up from 69. luacheck unchanged, 0 errors.