Fix edge case when doing el.texture.src = 'some-valid-src'

[guilhermesimoes]

Fix regression introduced in #616, that manifests in the following case:

1. Element is already active (visible and within bounds)
2. We set an invalid src, like el.src = '' or el.src = undefined
3. Finally we do el.texture.src = 'some-valid-src'

If on step 3 we do el.src = 'some-valid-src' then everything works ok.
If between steps 2 and 3 the element goes inactive and then active, everything also works ok.

We're currently refactoring the Peacock app to always do el.src = '...' instead of el.texture.src = '...' precisely because these setters go through slightly different paths and their behaviours differ.

[guilhermesimoes]

Basically this is the line that always needs to run when the element is enabled, whether the texture is valid or not.

[Copilot]

🟡 Changes recommended

The regression test explicitly forces loading instead of validating the documented automatic loading path.

1 open finding

• Test bypasses automatic texture update scheduling · New

What changed in this PR

Fixes texture recovery when an active element’s invalid texture is later given a valid source.

Changes:

• Registers enabled elements with invalid textures.
• Adds regression coverage for invalid-to-valid sources.

File	Description
src/​tree/​Element.mjs	Registers textures before validity checks.
tests/​textures/​test.textures.js	Adds invalid-to-valid loading coverage.

🧠 Review effort: Balanced

---

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

[Copilot]

🔵 Needs a closer look

The regression test does not make the element active before changing its source, so it misses the reported failure path.

0 open findings

1 resolved since last review

• Test bypasses automatic texture update scheduling

Previously missed (1)

In code that hasn't changed since last review

Test does not reproduce active-element regression

tests/​textures/​test.textures.js:186

This does not currently reproduce the reported active-element regression: the first animation frame runs only after the synchronous item.src assignments, and a new element starts outside the bounds margin, so it transitions from inactive to active afterward—the path the PR description says already works. Draw one frame (and assert active) before assigning the invalid source so this test fails against the regressed implementation.

🧠 Review effort: Balanced

---

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

[github-advanced-security]

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

• The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
• Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
• You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.