Skip to content

Fix TTS event wire names to use camelCase #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swethasukumarr merged 1 commit into from
Sep 24, 2026
+40 −40
Merged

Fix TTS event wire names to use camelCase #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions docs/openrpc/the-spec/firebolt-open-rpc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3490,15 +3490,15 @@
}
},
{
"name": "TextToSpeech.onWillspeak",
"name": "TextToSpeech.onWillSpeak",
"summary": "Text to speech conversion is about to start.",
"tags": [
{
"name": "rpc-only"
},
{
"name": "event",
"x-notifier": "TextToSpeech.onWillspeak"
"x-notifier": "TextToSpeech.onWillSpeak"
},
{
"name": "capabilities",
Expand Down Expand Up @@ -3538,15 +3538,15 @@
}
},
{
"name": "TextToSpeech.onSpeechstart",
"name": "TextToSpeech.onSpeechStart",
"summary": "Utterance is about to be spoken.",
"tags": [
{
"name": "rpc-only"
},
{
"name": "event",
"x-notifier": "TextToSpeech.onSpeechstart"
"x-notifier": "TextToSpeech.onSpeechStart"
},
{
"name": "capabilities",
Expand Down Expand Up @@ -3586,15 +3586,15 @@
}
},
{
"name": "TextToSpeech.onSpeechpause",
"name": "TextToSpeech.onSpeechPause",
"summary": "Ongoing speech was paused.",
"tags": [
{
"name": "rpc-only"
},
{
"name": "event",
"x-notifier": "TextToSpeech.onSpeechpause"
"x-notifier": "TextToSpeech.onSpeechPause"
},
{
"name": "capabilities",
Expand Down Expand Up @@ -3634,15 +3634,15 @@
}
},
{
"name": "TextToSpeech.onSpeechresume",
"name": "TextToSpeech.onSpeechResume",
"summary": "Paused speech was resumed.",
"tags": [
{
"name": "rpc-only"
},
{
"name": "event",
"x-notifier": "TextToSpeech.onSpeechresume"
"x-notifier": "TextToSpeech.onSpeechResume"
},
{
"name": "capabilities",
Expand Down Expand Up @@ -3682,15 +3682,15 @@
}
},
{
"name": "TextToSpeech.onSpeechcomplete",
"name": "TextToSpeech.onSpeechComplete",
"summary": "Speech completed successfully.",
"tags": [
{
"name": "rpc-only"
},
{
"name": "event",
"x-notifier": "TextToSpeech.onSpeechcomplete"
"x-notifier": "TextToSpeech.onSpeechComplete"
},
{
"name": "capabilities",
Expand Down Expand Up @@ -3730,15 +3730,15 @@
}
},
{
"name": "TextToSpeech.onSpeechinterrupted",
"name": "TextToSpeech.onSpeechInterrupted",
"summary": "Speech was stopped, due to another call to speak or cancel.",
"tags": [
{
"name": "rpc-only"
},
{
"name": "event",
"x-notifier": "TextToSpeech.onSpeechinterrupted"
"x-notifier": "TextToSpeech.onSpeechInterrupted"
},
{
"name": "capabilities",
Expand Down Expand Up @@ -3778,15 +3778,15 @@
}
},
{
"name": "TextToSpeech.onNetworkerror",
"name": "TextToSpeech.onNetworkError",
"summary": "Utterance failed due to network error.",
"tags": [
{
"name": "rpc-only"
},
{
"name": "event",
"x-notifier": "TextToSpeech.onNetworkerror"
"x-notifier": "TextToSpeech.onNetworkError"
},
{
"name": "capabilities",
Expand Down Expand Up @@ -3826,15 +3826,15 @@
}
},
{
"name": "TextToSpeech.onPlaybackerror",
"name": "TextToSpeech.onPlaybackError",
"summary": "Utterance failed during playback.",
"tags": [
{
"name": "rpc-only"
},
{
"name": "event",
"x-notifier": "TextToSpeech.onPlaybackerror"
"x-notifier": "TextToSpeech.onPlaybackError"
},
{
"name": "capabilities",
Expand Down
16 changes: 8 additions & 8 deletions src/texttospeech_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,47 +99,47 @@ Result<SpeechStateResponse> TextToSpeechImpl::getSpeechState(SpeechId speechId)

Result<SubscriptionId> TextToSpeechImpl::subscribeOnWillSpeak(std::function<void(const SpeechIdEvent&)>&& notification)
{
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onWillspeak", std::move(notification));
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onWillSpeak", std::move(notification));
}

Result<SubscriptionId> TextToSpeechImpl::subscribeOnSpeechStart(std::function<void(const SpeechIdEvent&)>&& notification)
{
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onSpeechstart", std::move(notification));
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onSpeechStart", std::move(notification));
}

Result<SubscriptionId> TextToSpeechImpl::subscribeOnSpeechPause(std::function<void(const SpeechIdEvent&)>&& notification)
{
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onSpeechpause", std::move(notification));
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onSpeechPause", std::move(notification));
}

Result<SubscriptionId> TextToSpeechImpl::subscribeOnSpeechResume(std::function<void(const SpeechIdEvent&)>&& notification)
{
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onSpeechresume",
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onSpeechResume",
std::move(notification));
}

Result<SubscriptionId> TextToSpeechImpl::subscribeOnSpeechComplete(std::function<void(const SpeechIdEvent&)>&& notification)
{
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onSpeechcomplete",
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onSpeechComplete",
std::move(notification));
}

Result<SubscriptionId>
TextToSpeechImpl::subscribeOnSpeechInterrupted(std::function<void(const SpeechIdEvent&)>&& notification)
{
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onSpeechinterrupted",
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onSpeechInterrupted",
std::move(notification));
}

Result<SubscriptionId> TextToSpeechImpl::subscribeOnNetworkError(std::function<void(const SpeechIdEvent&)>&& notification)
{
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onNetworkerror",
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onNetworkError",
std::move(notification));
}

Result<SubscriptionId> TextToSpeechImpl::subscribeOnPlaybackError(std::function<void(const SpeechIdEvent&)>&& notification)
{
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onPlaybackerror",
return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onPlaybackError",
std::move(notification));
}

Expand Down
16 changes: 8 additions & 8 deletions test/component/textToSpeechTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ TEST_F(TextToSpeechCTest, subscribeOnWillSpeak)

verifyEventSubscription(id);

triggerEvent("TextToSpeech.onWillspeak", R"({ "speechid": 1 })");
triggerEvent("TextToSpeech.onWillSpeak", R"({ "speechid": 1 })");

verifyEventReceived(mtx, cv, eventReceived);

Expand Down Expand Up @@ -171,7 +171,7 @@ TEST_F(TextToSpeechCTest, subscribeOnSpeechStart)

verifyEventSubscription(id);

triggerEvent("TextToSpeech.onSpeechstart", R"({ "speechid": 1 })");
triggerEvent("TextToSpeech.onSpeechStart", R"({ "speechid": 1 })");

verifyEventReceived(mtx, cv, eventReceived);

Expand Down Expand Up @@ -199,7 +199,7 @@ TEST_F(TextToSpeechCTest, subscribeOnSpeechComplete)

verifyEventSubscription(id);

triggerEvent("TextToSpeech.onSpeechcomplete", R"({ "speechid": 1 })");
triggerEvent("TextToSpeech.onSpeechComplete", R"({ "speechid": 1 })");

verifyEventReceived(mtx, cv, eventReceived);

Expand Down Expand Up @@ -227,7 +227,7 @@ TEST_F(TextToSpeechCTest, subscribeOnSpeechPause)

verifyEventSubscription(id);

triggerEvent("TextToSpeech.onSpeechpause", R"({ "speechid": 1 })");
triggerEvent("TextToSpeech.onSpeechPause", R"({ "speechid": 1 })");

verifyEventReceived(mtx, cv, eventReceived);

Expand Down Expand Up @@ -255,7 +255,7 @@ TEST_F(TextToSpeechCTest, subscribeOnSpeechResume)

verifyEventSubscription(id);

triggerEvent("TextToSpeech.onSpeechresume", R"({ "speechid": 1 })");
triggerEvent("TextToSpeech.onSpeechResume", R"({ "speechid": 1 })");

verifyEventReceived(mtx, cv, eventReceived);

Expand All @@ -282,7 +282,7 @@ TEST_F(TextToSpeechCTest, subscribeOnSpeechInterrupted)

verifyEventSubscription(id);

triggerEvent("TextToSpeech.onSpeechinterrupted", R"({ "speechid": 1 })");
triggerEvent("TextToSpeech.onSpeechInterrupted", R"({ "speechid": 1 })");

verifyEventReceived(mtx, cv, eventReceived);

Expand Down Expand Up @@ -310,7 +310,7 @@ TEST_F(TextToSpeechCTest, subscribeOnNetworkError)

verifyEventSubscription(id);

triggerEvent("TextToSpeech.onNetworkerror", R"({ "speechid": 1 })");
triggerEvent("TextToSpeech.onNetworkError", R"({ "speechid": 1 })");

verifyEventReceived(mtx, cv, eventReceived);

Expand Down Expand Up @@ -338,7 +338,7 @@ TEST_F(TextToSpeechCTest, subscribeOnPlaybackError)

verifyEventSubscription(id);

triggerEvent("TextToSpeech.onPlaybackerror", R"({ "speechid": 1 })");
triggerEvent("TextToSpeech.onPlaybackError", R"({ "speechid": 1 })");

verifyEventReceived(mtx, cv, eventReceived);

Expand Down
16 changes: 8 additions & 8 deletions test/unit/textToSpeechTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ TEST_F(TextToSpeechUTest, getSpeechState)

TEST_F(TextToSpeechUTest, subscribeOnWillSpeak)
{
mockSubscribe("TextToSpeech.onWillspeak");
mockSubscribe("TextToSpeech.onWillSpeak");

auto id = ttsImpl.subscribeOnWillSpeak([](auto) {});
ASSERT_TRUE(id) << "error on subscribe ";
Expand All @@ -257,7 +257,7 @@ TEST_F(TextToSpeechUTest, subscribeOnWillSpeak)

TEST_F(TextToSpeechUTest, subscribeOnSpeechStart)
{
mockSubscribe("TextToSpeech.onSpeechstart");
mockSubscribe("TextToSpeech.onSpeechStart");

auto id = ttsImpl.subscribeOnSpeechStart([](auto) {});
ASSERT_TRUE(id) << "error on subscribe ";
Expand All @@ -268,7 +268,7 @@ TEST_F(TextToSpeechUTest, subscribeOnSpeechStart)

TEST_F(TextToSpeechUTest, subscribeOnSpeechPause)
{
mockSubscribe("TextToSpeech.onSpeechpause");
mockSubscribe("TextToSpeech.onSpeechPause");

auto id = ttsImpl.subscribeOnSpeechPause([](auto) {});
ASSERT_TRUE(id) << "error on subscribe ";
Expand All @@ -279,7 +279,7 @@ TEST_F(TextToSpeechUTest, subscribeOnSpeechPause)

TEST_F(TextToSpeechUTest, subscribeOnSpeechResume)
{
mockSubscribe("TextToSpeech.onSpeechresume");
mockSubscribe("TextToSpeech.onSpeechResume");

auto id = ttsImpl.subscribeOnSpeechResume([](auto) {});
ASSERT_TRUE(id) << "error on subscribe ";
Expand All @@ -290,7 +290,7 @@ TEST_F(TextToSpeechUTest, subscribeOnSpeechResume)

TEST_F(TextToSpeechUTest, subscribeOnSpeechComplete)
{
mockSubscribe("TextToSpeech.onSpeechcomplete");
mockSubscribe("TextToSpeech.onSpeechComplete");

auto id = ttsImpl.subscribeOnSpeechComplete([](auto) {});
ASSERT_TRUE(id) << "error on subscribe ";
Expand All @@ -301,7 +301,7 @@ TEST_F(TextToSpeechUTest, subscribeOnSpeechComplete)

TEST_F(TextToSpeechUTest, subscribeOnSpeechInterrupted)
{
mockSubscribe("TextToSpeech.onSpeechinterrupted");
mockSubscribe("TextToSpeech.onSpeechInterrupted");

auto id = ttsImpl.subscribeOnSpeechInterrupted([](auto) {});
ASSERT_TRUE(id) << "error on subscribe ";
Expand All @@ -312,7 +312,7 @@ TEST_F(TextToSpeechUTest, subscribeOnSpeechInterrupted)

TEST_F(TextToSpeechUTest, subscribeOnNetworkError)
{
mockSubscribe("TextToSpeech.onNetworkerror");
mockSubscribe("TextToSpeech.onNetworkError");

auto id = ttsImpl.subscribeOnNetworkError([](auto) {});
ASSERT_TRUE(id) << "error on subscribe ";
Expand All @@ -323,7 +323,7 @@ TEST_F(TextToSpeechUTest, subscribeOnNetworkError)

TEST_F(TextToSpeechUTest, subscribeOnPlaybackError)
{
mockSubscribe("TextToSpeech.onPlaybackerror");
mockSubscribe("TextToSpeech.onPlaybackError");

auto id = ttsImpl.subscribeOnPlaybackError([](auto) {});
ASSERT_TRUE(id) << "error on subscribe ";
Expand Down
Loading