RDKEMW-26413 : Support generic JSON intents

[swethasukumarr]

No description provided.

[Copilot]

Copilot review overview

🟡 Changes recommended

The public dependency boundary and generator-owned files need correction before approval.

Review effort: Balanced
Findings: 1 · 4

Open (5)

• Test non-object JSON payloads in start() · New
• Update generator instead of editing generated public header · New
• Generate generic-intent serialization instead of editing output · New
• Regenerate implementation header from updated generator · New
• Update generator for generic JSON deserialization · New

What changed in this PR

Adds generic JSON intent payload support across the Actions API, transport adapter, specification, demo, and tests.

Changes:

• Replaces typed intent data with generic JSON payloads.
• Updates OpenRPC schemas and intent forwarding.
• Adds JSON dependency propagation and broader payload tests.

File	Description
include/​firebolt/​actions.h	Exposes generic intent payloads.
src/​actions_impl.h	Updates the start signature.
src/​actions_impl.cpp	Forwards JSON intents unchanged.
src/​json_types/​actions.h	Preserves generic response payloads.
src/​CMakeLists.txt	Makes nlohmann JSON public.
cmake/​FireboltClientConfig.cmake.in	Finds the exported JSON dependency.
docs/​openrpc/​the-spec/​firebolt-open-rpc.json	Generalizes intent schemas and examples.
test/​unit/​actionsTest.cpp	Tests getter and start behavior.
test/​unit/​actionsGeneratedTest.cpp	Tests generic subscription dispatch.
test/​component/​actionsGeneratedTest.cpp	Tests generic intents end-to-end.
test/​api_test_app/​apis/​actionsDemo.cpp	Demonstrates generic JSON usage.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

The public API introduces unsafe ABI breaks and exposes a prohibited implementation dependency while generator-owned artifacts lose their ownership markers.

Review effort: Balanced
Findings: 2

Open (2)

• Preserve Intent ABI layout · New
• Preserve virtual method ABI compatibility · New

Resolved since last review (5)

• Test non-object JSON payloads in start()
• Update generator for generic JSON deserialization
• Regenerate implementation header from updated generator
• Generate generic-intent serialization instead of editing output
• Update generator instead of editing generated public header

Previously missed (2)

In code that hasn't changed since last review

Avoid exposing nlohmann::json in public headers

include/​firebolt/​actions.h:24

Public Firebolt headers must not expose nlohmann::json. Making this implementation library part of the installed API couples every consumer to its headers and ABI; the new PUBLIC CMake dependency does not restore the public/JSON-layer boundary. Represent generic payloads with a Firebolt-owned public type (or serialized JSON) and convert to nlohmann::json inside the implementation/adapter layer.

Add malformed response and invalid event tests

src/​json_types/​actions.h:40

The deserialization contract changed, but the Actions tests still have no malformed-response case for the envelope validation here (for example, missing intentId or a non-unsigned ID). Add unit and component negative tests that assert the getter fails and an invalid event does not invoke its callback, matching the repository's getter/event pairing rules.

[Copilot]

Copilot review overview

🟡 Changes recommended

Generator-owned files were edited directly, the public API conflicts with the established contract, and an obsolete duplicate specification was added.

Review effort: Balanced
Findings: 2 · 2 · 3

Open (7)

• Return complete serialized intent objects from Actions API · New
• Preserve virtual method ABI compatibility
• Generate generic-payload assertions via firebolt-sdk-gen · New
• Generate new Actions test case via firebolt-sdk-gen · New
• Remove stale duplicate OpenRPC fixture · New
• Correct comment claiming byte-for-byte JSON preservation · New
• Update changelog for removed Actions APIs · New

Resolved since last review (1)

• Preserve Intent ABI layout

[Copilot]

Copilot review overview

🟡 Changes recommended

Generated artifacts were edited outside their generator workflow, and the TextToSpeech casing note contradicts the protocol specification.

Review effort: Balanced
Findings: 1

Open (1)

• Restore lowercase protocol event names in artifacts and release note · New

Resolved since last review (7)

• Return complete serialized intent objects from Actions API
• Preserve virtual method ABI compatibility
• Generate new Actions test case via firebolt-sdk-gen
• Generate generic-payload assertions via firebolt-sdk-gen
• Update changelog for removed Actions APIs
• Correct comment claiming byte-for-byte JSON preservation
• Remove stale duplicate OpenRPC fixture

[Copilot]

Copilot review overview

🔵 Needs a closer look

Generator-owned files were edited directly, and malformed response deserialization lacks required coverage.

Review effort: Balanced
Findings: None

Resolved since last review (1)

• Restore lowercase protocol event names in artifacts and release note

Previously missed (1)

In code that hasn't changed since last review

Add malformed wire-response coverage for intent deserialization

src/​json_types/​actions.h:40

The new deserializer's malformed-wire-response path is not covered: the transport-error test returns before fromJson() runs, and current tests only provide valid envelopes. Add an Actions.intent unit test with a missing required field or invalid intentId type and assert Error::InvalidParams, matching getter coverage elsewhere in the repository.

[Copilot]

Copilot review overview

🟡 Changes recommended

Generated files are edited directly, JSON conversion violates layer boundaries, validation coverage is incomplete, and the TextToSpeech casing claim conflicts with the protocol.

Review effort: Balanced
Findings: 2

Open (2)

• Move intent JSON conversion into the Actions adapter · New
• Add negative coverage for intent responses and invalid events · New