Repository navigation
Sync main - #121
Merged
Merged
Sync main#121
Conversation
Include token in release workflow
* chore: transport to latest * fix: cov_build.sh fixes * chore: add missing dep * nojira: fix videoutput ser/deserialization bug(s) * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * nojira: fix json * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix: tighten up videooutput parser ut * RDKEMW-2473: more fixes * Refactor and fix issues * Fix tests and format * Update speechsynthesis api's to match firebolt 9 spec * Address copilot comments * Refactor code --------- Co-authored-by: swethasukumarr <swethasukumar03@gmail.com> Co-authored-by: bobra200 <bobra200@cable.comcast.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* chore: transport to latest * fix: cov_build.sh fixes * chore: add missing dep * sync main (#109) * Replace semantic-release with developer-controlled version bump workflow * Address copilot comments * Refactor release workflow * Address copilot comments * Address copilot comments * Add changelog for upcoming 0.7 release * Include token in release workflow * Push tag over ssh via deploy key, not the Releases API * Address copilot comments * Fix deploy key variable * Address copilot comments * RDKEMW-24783: Videouput bad json (ser)deserialization (#108) * chore: transport to latest * fix: cov_build.sh fixes * chore: add missing dep * nojira: fix videoutput ser/deserialization bug(s) * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * nojira: fix json * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix: tighten up videooutput parser ut * RDKEMW-2473: more fixes * Refactor and fix issues * Fix tests and format * Update speechsynthesis api's to match firebolt 9 spec * Address copilot comments * Refactor code --------- Co-authored-by: swethasukumarr <swethasukumar03@gmail.com> Co-authored-by: bobra200 <bobra200@cable.comcast.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Brendan O'Bra <brendan@obrafamily.org> Co-authored-by: bobra200 <bobra200@cable.comcast.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Brendan O'Bra <brendan@obrafamily.org> Co-authored-by: bobra200 <bobra200@cable.comcast.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Fix release workflow
RDKEMW-25136 : Add Device.name and Device.onNameChanged api implementation
Fix TTS event wire names to use camelCase
ci: install sync-develop-to-main workflow via app-gateway-automation …
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| name: Merge ${{ github.event.inputs.source_branch || 'develop' }} → ${{ github.event.inputs.target_branch || 'main' }} | ||
| runs-on: comcast-ubuntu-latest | ||
| steps: | ||
| - uses: rdk-e/app-gateway-automation/actions/sync-branches@actions-v1 |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Release validation is weakened, TextToSpeech names conflict with protocol sources, and affected component tests are excluded.
4 open findings
What changed in this PR
Synchronizes API, protocol fixtures, tests, and automation with recent mainline changes.
Changes:
- Generalizes Actions intent payloads as serialized JSON.
- Adds
Device.nameand name-change subscriptions. - Updates TextToSpeech events and CI/release workflows.
| File | Description |
|---|---|
include/firebolt/actions.h |
Revises the Actions public API. |
include/firebolt/device.h |
Adds device-name APIs. |
src/actions_impl.h |
Updates Actions implementation declarations. |
src/actions_impl.cpp |
Parses generic intent JSON. |
src/json_types/actions.h |
Preserves intent payloads as JSON text. |
src/device_impl.h |
Declares device-name operations. |
src/device_impl.cpp |
Implements device-name operations. |
src/texttospeech_impl.cpp |
Changes TextToSpeech event identifiers. |
src/firebolt.cpp |
Cleans up Device subscriptions. |
test/unit/actionsTest.cpp |
Tests generic Actions payloads. |
test/unit/actionsGeneratedTest.cpp |
Tests generic event dispatch. |
test/unit/deviceTest.cpp |
Tests device-name APIs. |
test/unit/textToSpeechTest.cpp |
Updates expected event identifiers. |
test/component/actionsGeneratedTest.cpp |
Exercises generic intent payloads. |
test/component/deviceTest.cpp |
Exercises device-name APIs. |
test/component/textToSpeechTest.cpp |
Updates TextToSpeech event triggers. |
test/api_test_app/apis/actionsDemo.cpp |
Demonstrates JSON intent handling. |
test/api_test_app/apis/deviceDemo.cpp |
Demonstrates device-name retrieval. |
docs/openrpc/the-spec/firebolt-open-rpc.json |
Updates API schemas and fixtures. |
docs/ci/text-to-speech-component-test-exclusion.md |
Documents temporary test exclusions. |
README.md |
Notes the CI exclusion. |
CHANGELOG.md |
Records release-facing changes. |
.github/workflows/ci.yml |
Excludes TextToSpeech component tests. |
.github/workflows/release.yml |
Changes release baseline validation. |
.github/workflows/sync-develop-to-main.yml |
Adds branch synchronization automation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # into this branch's history rather than true-merged), so ancestry can't be | ||
| # relied on here. Compare tree content instead: if HEAD's tree is identical to | ||
| # BASELINE's, there's nothing new to release. | ||
| if [ "$(git rev-parse "${BASELINE}^{tree}")" = "$(git rev-parse "HEAD^{tree}")" ]; then |
| Result<SubscriptionId> TextToSpeechImpl::subscribeOnWillSpeak(std::function<void(const SpeechIdEvent&)>&& notification) | ||
| { | ||
| return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onWillspeak", std::move(notification)); | ||
| return subscriptionManager_.subscribe<JsonData::SpeechIdEvent>("TextToSpeech.onWillSpeak", std::move(notification)); |
Comment on lines
+269
to
+272
| # Temporary exclusion for TextToSpeech event tests. See docs/ci/text-to-speech-component-test-exclusion.md. | ||
| EXCLUDED_COMPONENT_TESTS="TextToSpeechCTest.subscribeOnWillSpeak:TextToSpeechCTest.subscribeOnSpeechStart:TextToSpeechCTest.subscribeOnSpeechComplete:TextToSpeechCTest.subscribeOnSpeechPause:TextToSpeechCTest.subscribeOnSpeechResume:TextToSpeechCTest.subscribeOnSpeechInterrupted:TextToSpeechCTest.subscribeOnNetworkError:TextToSpeechCTest.subscribeOnPlaybackError" | ||
| chmod +x ${{ github.workspace }}/build/test/ctApp | ||
| docker run --rm --user "$(id -u):$(id -g)" -v ${{ github.workspace }}:/workspace -v ${{ env.MOCK_PATH }}:/mock ${{ needs.build_docker.outputs.image_tag }} \ | ||
| docker run --rm --user "$(id -u):$(id -g)" -e GTEST_FILTER="-$EXCLUDED_COMPONENT_TESTS" -v ${{ github.workspace }}:/workspace -v ${{ env.MOCK_PATH }}:/mock ${{ needs.build_docker.outputs.image_tag }} \ |
| // ============================================================================ | ||
| // AUTO-GENERATED by fb-gen — DO NOT EDIT | ||
| // ============================================================================ | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.