Repository navigation
chore: auto-sync develop → main (direct push failure) - #141
Open
swethasukumarr wants to merge 3 commits into
Open
swethasukumarr wants to merge 3 commits into
swethasukumarr wants to merge 3 commits into
Conversation
Align transport release workflow with client safeguards
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Release-branch validation permits mismatched versions, and the changelog removes documented RC history.
2 open findings
What changed in this PR
Synchronizes release updates from develop into main and hardens the release workflow.
Changes:
- Promotes the changelog entry to version 1.1.12.
- Adds branch, changelog, concurrency, and existing-tag safeguards.
| File | Description |
|---|---|
CHANGELOG.md |
Updates the latest release heading. |
.github/workflows/release.yml |
Strengthens release validation and retry safety. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+49
to
+53
| branch="${GITHUB_REF_NAME}" | ||
| if [[ "$branch" == "main" || "$branch" =~ ^[0-9]+\.[0-9]+(-rc|\.x-maintenance)$ ]]; then | ||
| echo "Release allowed from branch: $branch" | ||
| else | ||
| echo "Release blocked: branch '$branch' is not allowed. Use 'main', an 'N.N-rc' branch, or an 'N.N.x-maintenance' branch." |
| @@ -1,4 +1,4 @@ | |||
| ## [1.1.12.rc1](https://github.com/rdkcentral/firebolt-cpp-transport/compare/v1.1.11...v1.1.12.rc1) | |||
| ## [1.1.12](https://github.com/rdkcentral/firebolt-cpp-transport/compare/v1.1.11...v1.1.12) | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic sync of
develop→maincould not complete via direct workflow push.Action required: resolve the conflicts in this PR, then merge it.
Detected reason: direct push failure
Triggered by: 374f09a on develop