Skip to content

VPAAMP-1341: Fix MP4 demux unknown-format stream setup - #274

Merged
rekhap2kandhavelan merged 2 commits into
developfrom
feature/vpaamp-1341
Oct 9, 2026
Merged

rekhap2kandhavelan merged 2 commits into
developfrom
feature/vpaamp-1341

Conversation

@pstroffolino

Copy link
Copy Markdown

Reason for Change: We have three failing L2 tests (7002 13004 2005) since middleware changes for VPAAMP-959 "MP4DEMUX]Use codec info from the manifest rather than lazy caps setting" were merged.
RCA: All three failures share one signature in the gitrunner logs. In ConfigurePipeline, the video track is never set up when the manifest does not reveal a video format.
Format 16 is GST_FORMAT_UNKNOWN (last entry of GstStreamOutputFormat in GstUtils.h). Because no appsrc is created for stream 0, the video injector thread blocks in BlockUntilGstreamerWantsData forever and the tune never reaches PLAYING. In the 7002 log the init segment is only parsed at 20.0s, during teardown — SetStreamCaps for type 0 appears at the very end, after the test already timed out.

Copilot AI balanced review requested due to automatic review settings October 3, 2026 00:43
@pstroffolino
pstroffolino requested a review from a team as a code owner October 3, 2026 00:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new condition incorrectly counts an UNKNOWN-to-INVALID transition without reconfiguring a stream.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Enables initial stream setup when manifests report an unknown format, allowing later demuxer caps discovery.

Changes:

  • Reconfigures initially unknown-format streams.
  • Adds regression coverage for unknown video formats.
File Description
InterfacePlayerRDK.cpp Updates pipeline reconfiguration logic.
test/​utests/​tests/​InterfacePlayerTests/​InterfacePlayerFunctionTests.cpp Tests initial unknown-format setup.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread InterfacePlayerRDK.cpp
@varshnie
varshnie force-pushed the feature/vpaamp-1341 branch from 01ed898 to b3832ae Compare October 6, 2026 06:13
Copilot AI balanced review requested due to automatic review settings October 6, 2026 06:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

An undefined enum breaks compilation, and an unknown-to-invalid transition corrupts the track count.

Review effort: Balanced
Findings: 1 High severity · 2 Medium severity

Open (3)

Comment thread test/utests/tests/InterfacePlayerTests/InterfacePlayerFunctionTests.cpp Outdated
Comment thread InterfacePlayerRDK.cpp
@varshnie
varshnie force-pushed the feature/vpaamp-1341 branch from b3832ae to 21bac22 Compare October 6, 2026 07:20
Copilot AI balanced review requested due to automatic review settings October 6, 2026 07:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The targeted fix is correctly constrained and has appropriate regression coverage.

Review effort: Balanced
Findings: None

Resolved since last review (3)

@varshnie
varshnie force-pushed the feature/vpaamp-1341 branch from 21bac22 to 04e64c3 Compare October 6, 2026 12:41
Copilot AI balanced review requested due to automatic review settings October 6, 2026 12:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

One decision-matrix test uses inputs that contradict its expected result and will fail.

Review effort: Balanced
Findings: 1 High severity

Open (1)

Comment thread test/utests/tests/InterfacePlayerTests/InterfacePlayerFunctionTests.cpp Outdated
Copilot AI balanced review requested due to automatic review settings October 6, 2026 12:51
@varshnie
varshnie force-pushed the feature/vpaamp-1341 branch from 04e64c3 to b64fb7b Compare October 6, 2026 12:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused logic change addresses the reported deadlock scenario and is comprehensively covered by unit tests.

Review effort: Balanced
Findings: None

Resolved since last review (1)

mageshgopal56
mageshgopal56 previously approved these changes Oct 7, 2026

@mageshgopal56 mageshgopal56 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

Comment thread test/utests/tests/InterfacePlayerTests/InterfacePlayerFunctionTests.cpp Outdated
Copilot AI balanced review requested due to automatic review settings October 8, 2026 17:07
@Vinish100
Vinish100 force-pushed the feature/vpaamp-1341 branch from 5da788b to e2b498c Compare October 8, 2026 17:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused logic change addresses the reported deadlock and is comprehensively covered by unit tests.

0 open findings

🧠 Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 8, 2026 17:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The functional fix is sound; only two minor misleading test parameter names remain.

1 open finding

🧠 Review effort: Balanced

Comment thread test/utests/tests/InterfacePlayerTests/InterfacePlayerFunctionTests.cpp Outdated
Copilot AI balanced review requested due to automatic review settings October 8, 2026 17:16
@Vinish100
Vinish100 force-pushed the feature/vpaamp-1341 branch from e2b498c to 3b531f2 Compare October 8, 2026 17:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The revised condition addresses the reported failure while preserving valid-format and encryption behavior with comprehensive tests.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

@mageshgopal56 mageshgopal56 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@rekhap2kandhavelan
rekhap2kandhavelan merged commit 3c8cee9 into develop Oct 9, 2026
9 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants