Repository navigation
VPAAMP-1341: Fix MP4 demux unknown-format stream setup - #274
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new condition incorrectly counts an UNKNOWN-to-INVALID transition without reconfiguring a stream.
Review effort: Balanced
Findings: 1
What changed in this PR
Enables initial stream setup when manifests report an unknown format, allowing later demuxer caps discovery.
Changes:
- Reconfigures initially unknown-format streams.
- Adds regression coverage for unknown video formats.
| File | Description |
|---|---|
InterfacePlayerRDK.cpp |
Updates pipeline reconfiguration logic. |
test/utests/tests/InterfacePlayerTests/InterfacePlayerFunctionTests.cpp |
Tests initial unknown-format setup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
varshnie
force-pushed
the
feature/vpaamp-1341
branch
from
October 6, 2026 06:13
01ed898 to
b3832ae
Compare
varshnie
force-pushed
the
feature/vpaamp-1341
branch
from
October 6, 2026 07:20
b3832ae to
21bac22
Compare
varshnie
force-pushed
the
feature/vpaamp-1341
branch
from
October 6, 2026 12:41
21bac22 to
04e64c3
Compare
varshnie
force-pushed
the
feature/vpaamp-1341
branch
from
October 6, 2026 12:51
04e64c3 to
b64fb7b
Compare
Vinish100
reviewed
Oct 7, 2026
Vinish100
force-pushed
the
feature/vpaamp-1341
branch
from
October 8, 2026 17:08
5da788b to
e2b498c
Compare
Vinish100
force-pushed
the
feature/vpaamp-1341
branch
from
October 8, 2026 17:16
e2b498c to
3b531f2
Compare
Vinish100
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Reason for Change: We have three failing L2 tests (7002 13004 2005) since middleware changes for VPAAMP-959 "MP4DEMUX]Use codec info from the manifest rather than lazy caps setting" were merged.
RCA: All three failures share one signature in the gitrunner logs. In ConfigurePipeline, the video track is never set up when the manifest does not reveal a video format.
Format 16 is GST_FORMAT_UNKNOWN (last entry of GstStreamOutputFormat in GstUtils.h). Because no appsrc is created for stream 0, the video injector thread blocks in BlockUntilGstreamerWantsData forever and the tune never reaches PLAYING. In the 7002 log the init segment is only parsed at 20.0s, during teardown — SetStreamCaps for type 0 appears at the very end, after the test already timed out.