Repository navigation
Conversation
…railto Decryption Errors Observed Reason for change : Expose rialto server failures to application Priority : P1 Test steps: Mentioned in ticket Signed off by : nejumatn28@gmail.com
…railto Decryption Errors Observed Reason for change : In case of rialtoserver failure, ocdm session is reinitialized Priority : P1 Test steps: Mentioned in ticket Signed off by : nejumatn28@gmail.com
…railto Decryption Errors Observed Reason for change : rebuild DRM session immediately on error state instead of latching failure Priority : P1 Test steps: Mentioned in ticket Signed off by : nejumatn28@gmail.com
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Failed-key caching can bypass recovery, while asynchronous state updates introduce data races.
5 open findings
What changed in this PR
Adds DRM recovery after Rialto/OpenCDM session termination.
Changes:
- Tracks and rebuilds invalidated OpenCDM sessions.
- Propagates OpenCDM errors through DRM callbacks.
- Avoids reusing invalidated cached sessions.
| File | Description |
|---|---|
drm/ocdm/opencdmsessionadapter.h |
Adds invalidation state and reinitialization support. |
drm/ocdm/opencdmsessionadapter.cpp |
Handles OpenCDM errors and resets sessions. |
drm/DrmSessionManager.cpp |
Rebuilds invalidated cached sessions. |
drm/DrmSession.h |
Adds the session invalidation API. |
drm/DrmCallbacks.h |
Adds error notification callback. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+179
to
+181
| userSession->m_keyStatus = InternalError; | ||
| userSession->m_eKeyState = KEY_ERROR; | ||
| userSession->m_sessionReinitializationRequired.store(true); |
| } | ||
|
|
||
| if (isKeyIdFound) | ||
| if (isKeyIdFound && !drmSessionContexts[sessionSlot].drmSession->IsInvalidated()) |
Comment on lines
+119
to
+124
| m_challenge.clear(); | ||
| m_destUrl.clear(); | ||
| m_keyStored.clear(); | ||
| m_keyStateIndeterminate = false; | ||
| m_keyStatus = InternalError; | ||
| m_eKeyState = KEY_INIT; |
|
|
||
| DrmHelperPtr m_drmHelper; | ||
| DrmCallbacks *m_drmCallbacks; | ||
| std::atomic<bool> m_sessionReinitializationRequired; |
| @@ -145,6 +169,23 @@ void OCDMSessionAdapter::generateDRMSession(const uint8_t *f_pbInitData, | |||
| }; | |||
|
|
|||
| m_OCDMSessionCallbacks.error_message_callback = [](OpenCDMSession* session, void* userData, const char message[]) { | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKEMW-26495: Linear Channel Playback Failure After Standby/reboot - railto Decryption Errors Observed
Reason for change : Handle rialto session termination gracefully and re initialise DRM
Priority : P1
Test steps: kill -11 should not cause techfault
Risks: Low
Signed-off-by : Nejuma T N nejumatn28@gmail.com