Skip to content

RDKEMW-25174 : Analytics events - #150

Open
vjain008 wants to merge 1 commit into
developfrom
topic/RDKEMW-25174dev
Open

vjain008 wants to merge 1 commit into
developfrom
topic/RDKEMW-25174dev

Conversation

@vjain008

@vjain008 vjain008 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Reason for change: Updated the Timer polyfills
Test Procedure: build should be successful.
Risks: low
Priority: P2

Reason for change: Updated the Timer polyfills
Test Procedure: build should be successful.
Risks: low
Priority: P2
Copilot AI balanced review requested due to automatic review settings October 8, 2026 18:04
@vjain008
vjain008 requested a review from a team as a code owner October 8, 2026 18:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The implementation does not match the stated timer-polyfill scope.

1 open finding
What changed in this PR

Adds an informational startup log to the runtime entry point.

Changes:

  • Logs entry into main() after argument validation.
  • Does not implement the timer-polyfill update described in the PR.
File Description
src/​jsruntime.cpp Adds a startup INFO log.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/jsruntime.cpp
@vjain008

vjain008 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

LCOV - code coverage report

Current view: top level Coverage Total Hit
Test: rdkNativeScript L1 Coverage Lines: 57.6 % 4927 2838
Test Date: 2026-10-08 18:27:21 Functions: 71.3 % 429 306

Directory Line Coverage (%) Line Coverage (Total) Line Coverage (Hit) Functions (%) Functions (Total) Functions (Hit)
src 80.3 % 1197 961 87.4 % 135 118
src/jsc 42.8 % 2750 1177 69.5 % 226 157
src/jsc/jsc_lib 44.6 % 504 225 42.2 % 64 27
src/linux 99.8 % 476 475 100.0 % 4 4

@vjain008

vjain008 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

LCOV - code coverage report

Current view: top level Coverage Total Hit
Test: rdkNativeScript L2 Coverage Lines: 56.8 % 3001 1706
Test Date: 2026-10-08 18:34:42 Functions: 65.8 % 322 212
Branches: 30.9 % 4639 1435

Directory Line Coverage (%) Line Coverage (Total) Line Coverage (Hit) Functions (%) Functions (Total) Functions (Hit)
include 100.0 % 49 49 38.6 % 70 27
include/jsc 92.1 % 38 35 68.8 % 16 11
src 59.1 % 1360 804 34.5 % 2005 692
src/jsc 52.6 % 1554 818 27.7 % 2548 705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants