Repository navigation
Every rewrite of an open statement keeps it a statement - #38
Merged
Merged
Conversation
rehome_tx (a merge undone) and correct_interval (PATCH /facts/{id}) copied
an open statement without its layer and phrase, as rewrite_end_tx did
before RC-004, so the copy became a typed row with no predicate that
materialize never read again. Both now copy them; RC-004 gets a dated note.
gedaiu
added a commit
to re-cinq/lore
that referenced
this pull request
Oct 24, 2026
Bumps `utopia_image_tag` to `0.1.0-re.23` and `utopia_image_digest` to `sha256:86591a57...`, the multi-arch index digest checked against ghcr. re.23 judges a typed fact as confirmed while the statement it was built from is still stated (re-cinq/utopia#37, RC-005): a re-push gives only the statement its new evidence, so typed rows kept a stale copy and looked unconfirmed, 71,025 of them in lore's base. It also keeps every rewrite of an open statement a statement (re-cinq/utopia#38: a merge undone and a corrected interval). No new migration since re.22. After merge: `terraform apply` from main. Related: #3413. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RC-004 found that
rewrite_end_txcopied an open statement without itslayerandphrase, so the copy became a typed row with no predicate that materialize never read again, and fixed that one insert. Two more rewrites had the same gap:rehome_tx(used when a merge is undone,resolution.rs) andcorrect_interval(PATCH /kbs/{kb}/facts/{id}). Both now copylayerandphrase. They were the last inserts intofactsthat copy an existing row:insert_fact_on,insert_open_statementand theknown_asinsert inresolution.rswrite new rows with their layer set. RC-004 gets a dated note.Tests:
a_statement_with_a_corrected_start_stays_open_and_its_typed_row_followsanda_statement_rehomed_to_bea_stays_open_and_its_typed_row_follows(both failed first with("typed", None, None));cargo test -p utopia-storeandcargo test --bin utopia-servergreen on a fresh migrated database; fmt and clippy-D warningsclean.Left as they are:
rehome_txalso dropsvalid_from_gradeandattested_byandcorrect_intervaldropsattested_by, compared withrewrite_end_tx; andPATCH /facts/{id}queues no typed recompute after correcting an open statement.🤖 Generated with Claude Code