Repository navigation
fix(scope): enforce scope violations on introspection failure and unsupported forges (#1622) - #1643
Open
nextlevelshit wants to merge 1 commit into
Open
nextlevelshit wants to merge 1 commit into
nextlevelshit wants to merge 1 commit into
Conversation
…1622) - Finding 1 (HIGH): introspection failure → ScopeViolation (was warning+skip) - Finding 2 (MED): nil introspector (unsupported forge) → per-scope violations (was warn+return) - Finding 3 (MED): fine-grained PAT hint updated to reference WAVE_SKIP_SCOPE_CHECK=1 - WAVE_SKIP_SCOPE_CHECK=1 bypass added for fine-grained PATs, unsupported forges, air-gapped envs - Docs: environment.md, manifest.md, concepts/personas.md
nextlevelshit
force-pushed
the
fix/scope-enforcement-1622
branch
from
May 2, 2026 13:09
ff5c6ab to
15db164
Compare
QuintinBotes
requested changes
Oct 2, 2026
QuintinBotes
left a comment
QuintinBotes
left a comment
There was a problem hiding this comment.
Changes requested: 2 comments, the highest important.
| if tokenInfo.TokenType == "fine-grained" { | ||
| hint = "fine-grained PATs cannot be introspected; recreate as classic PAT or set WAVE_SKIP_SCOPE_CHECK=1 to bypass" | ||
| } | ||
| result.Violations = append(result.Violations, ScopeViolation{ |
There was a problem hiding this comment.
important - GiteaIntrospector always sets tokenInfo.Error after a successful tea whoami, and this line turns that into a ScopeViolation. Every Gitea/Forgejo/Codeberg run with token_scopes fails preflight on a valid token; the hint omits WAVE_SKIP_SCOPE_CHECK.
| result := &ValidationResult{} | ||
|
|
||
| // If no introspector available (unknown forge), warn and skip | ||
| if os.Getenv("WAVE_SKIP_SCOPE_CHECK") != "" { |
There was a problem hiding this comment.
minor - os.Getenv("WAVE_SKIP_SCOPE_CHECK") != "" treats false or 0 as set. An explicit opt-out disables all scope validation, though docs list it as a bool. Parse it as a boolean like the other WAVE_* flags; bypass only when true.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1622.
Summary
Three token-scope enforcement gaps fixed (from
audit-securityF1 findings):ScopeViolationblocking execution (was warning+skip)WAVE_SKIP_SCOPE_CHECK=1added for fine-grained PATs, unsupported forges, air-gapped/CI environmentsDocs updated
docs/reference/environment.md—WAVE_SKIP_SCOPE_CHECKrow addeddocs/reference/manifest.md— introspection failure + fine-grained PAT + unsupported forge behavior documenteddocs/concepts/personas.md— bypass hint added to token scope sectionTest plan
go test ./internal/scope/...— 10/10 passgolangci-lint run ./internal/scope/...— 0 issuesWAVE_SKIP_SCOPE_CHECK=1 wave run ...— should bypass and warn