Skip to content

Fix 1-090_validate_permissions for OLM CSV copies on v1.19.6. - #1248

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:v1.19from
trdoyle81:fix-v1.19-1-090-validate-permissions
Aug 7, 2026
Merged

Fix 1-090_validate_permissions for OLM CSV copies on v1.19.6.#1248
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:v1.19from
trdoyle81:fix-v1.19-1-090-validate-permissions

Conversation

@trdoyle81

@trdoyle81 trdoyle81 commented Aug 6, 2026

Copy link
Copy Markdown
Member

Scope CSV lookup to openshift-gitops-operator and refresh expected cluster permissions so the test no longer fails when OLM copies the CSV into every namespace.

Assisted by: Cursor

What type of PR is this?

/kind failing-test

What does this PR do / why we need it:

1-090_validate_permissions failed on the 1.19.6 upgrade run because it listed GitOps CSVs cluster-wide and expected exactly one match. With AllNamespaces install mode, OLM copies the CSV into every namespace, so the assertion failed.

This change:

  • Lists CSVs only in openshift-gitops-operator
  • Updates the inline expected cluster permissions for 1.19.6
  • Improves the failure message to show CSV names/namespaces

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Focused rerun against the 1.19.6 upgrade cluster:

./bin/ginkgo -v --focus="1-090_validate_permissions" -r ./test/openshift/e2e/ginkgo/parallel

@openshift-ci openshift-ci Bot added the kind/failing-test Categorizes issue or PR as related to a frequently failing test. label Aug 6, 2026
@openshift-ci
openshift-ci Bot requested review from anandrkskd and jgwest August 6, 2026 14:15
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: af71bc33-7248-4c53-b5dd-20bbf6b7cd97

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Scope CSV lookup to openshift-gitops-operator and refresh expected cluster permissions so the test no longer fails when OLM copies the CSV into every namespace.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Triona Doyle <tekton@example.com>
@trdoyle81
trdoyle81 force-pushed the fix-v1.19-1-090-validate-permissions branch from 38cf44e to fac9c70 Compare August 6, 2026 14:55
@varshab1210

Copy link
Copy Markdown
Member

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: varshab1210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Aug 7, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 3efbdb4 into redhat-developer:v1.19 Aug 7, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved kind/failing-test Categorizes issue or PR as related to a frequently failing test. lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants