Fix 1-090_validate_permissions for OLM CSV copies on v1.19.6. - #1248
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Scope CSV lookup to openshift-gitops-operator and refresh expected cluster permissions so the test no longer fails when OLM copies the CSV into every namespace. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Triona Doyle <tekton@example.com>
38cf44e to
fac9c70
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: varshab1210 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3efbdb4
into
redhat-developer:v1.19
Scope CSV lookup to openshift-gitops-operator and refresh expected cluster permissions so the test no longer fails when OLM copies the CSV into every namespace.
Assisted by: Cursor
What type of PR is this?
/kind failing-test
What does this PR do / why we need it:
1-090_validate_permissionsfailed on the 1.19.6 upgrade run because it listed GitOps CSVs cluster-wide and expected exactly one match. With AllNamespaces install mode, OLM copies the CSV into every namespace, so the assertion failed.This change:
openshift-gitops-operatorHave you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
Focused rerun against the 1.19.6 upgrade cluster:
./bin/ginkgo -v --focus="1-090_validate_permissions" -r ./test/openshift/e2e/ginkgo/parallel