Repository navigation
Conversation
Signed-off-by: wwqgtxx <wwqgtxx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue stems from the order of extensions. In the standard ECH encoding, a contiguous sequence of extensions is compressed together and subsequently expanded by the server at the position of the
outer_extensionsplaceholder. With the current change, ALPN is encoded directly, while other extensions remain in the placeholder section. This can lead to the following discrepancy:Original Inner ClientHello: …
supported_groups→signature_algorithms→ ALPN → …Reconstructed Inner ClientHello (Server-side): … ALPN →
supported_groups→signature_algorithms→ …Although the content of the fields remains identical, the TLS transcript hash is computed over the raw bytes of the entire message—which includes the order of the extensions.
In the standard workflow, the transcript is computed directly from the original
innerHello(seehandshake_client_tls13.go:75). Consequently, while the server accepts the ECH, the client fails to correctly verify the acceptance confirmation, leading to a divergence in handshake state and key derivation between the two parties.This affects only:
ConnUConn+HelloGolang