Repository navigation
fix(a11y): add pause controls and WCAG 2.2.2 carousel semantics to TipCarousel - #1824
Open
chiragjangiir wants to merge 1 commit into
Open
chiragjangiir wants to merge 1 commit into
chiragjangiir wants to merge 1 commit into
Conversation
…pCarousel - Add pause-on-hover and pause-on-focus to satisfy WCAG 2.2.2 (Pause, Stop, Hide) - Add accessible play/pause toggle button with dynamic aria-label and aria-pressed - Respect prefers-reduced-motion media query by defaulting to paused state - Add carousel ARIA attributes (aria-roledescription, aria-label, aria-live, aria-current) - Add comprehensive unit test suite in src/components/__tests__/TipCarousel.test.tsx Closes reframe-oss#1773
👷 Deploy request for reframe-os pending review.Visit the deploys page to approve it
|
Contributor
✅ PR Format Check Passed — @chiragjangiirBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @chiragjangiir!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:advanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1773 by bringing
TipCarousel.tsxinto compliance with WCAG 2.2.2 (Pause, Stop, Hide). Previously, the tip carousel auto-advanced on an unyielding 6-second interval with no hover, focus, or visual pause controls, and lacked carousel accessibility semantics.Root Cause & Changes
onMouseEnter,onMouseLeave,onFocus, and containeronBlurlisteners to pause auto-advancement whenever a user is reading or interacting with the card or its controls.PauseandPlay),aria-pressed, and dynamicaria-label.(prefers-reduced-motion: reduce), defaulting to paused state for users sensitive to motion.aria-roledescription="carousel",aria-label="Workflow tips",aria-livepolite region, andaria-current="true"on the active pagination indicator.src/components/__tests__/TipCarousel.test.tsxverifying rotation, pause-on-hover, pause-on-focus, manual toggle, pagination selection, and reduced-motion initialization.Validation
src/components/__tests__/TipCarousel.test.tsx.TipCarousel.tsxand test suite.bun x tsc --noEmitcleanly passed with 0 errors.Closes #1773