fix(docs): verify future release tag against candidate source - #724
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d8216228f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - every linked repository path exists at that exact tag or commit | ||
| - every root-relative documentation route exists at the selected source commit | ||
|
|
||
| The exact source tag of the newest validated release manifest is the only |
There was a problem hiding this comment.
The reviewed commit message has no Signed-off-by: trailer, so it violates the repository's mandatory DCO policy and will be rejected by the DCO gate; recreate the commit with git commit -s.
AGENTS.md reference: AGENTS.md:L274-L274
Useful? React with 👍 / 👎.
| if (!gitObjectExists(repoRoot, `${commitish}^{commit}`, gitCommand)) { | ||
| return `references missing Git commit or tag ${ref}`; | ||
| if (ref !== candidateTag || !gitObjectExists(repoRoot, `${sourceRef}^{commit}`, gitCommand)) { | ||
| return `references missing Git commit or tag ${ref}`; | ||
| } | ||
| commitish = sourceRef; |
There was a problem hiding this comment.
When the candidate ref exists but cannot peel to a commit, such as when refs/tags/v9.9.9 points to a blob or its target commit is absent from an incomplete checkout, this lookup fails and the branch silently substitutes sourceRef. I reproduced this with a blob tag: the check accepted evidence at v9.9.9 against HEAD even though that tag already existed, leaving the claim unanchored at its stated tag; check whether the tag ref itself exists separately and reject an existing tag that cannot resolve to a commit.
AGENTS.md reference: docs/site/AGENTS.md:L25-L28
Useful? React with 👍 / 👎.
1 participant
Summary
This is a train-independent prerequisite for release PR #723. It must land before the v0.20.0 release metadata.
Verification