Skip to content

docs(release): clarify protected main candidate source - #732

Merged
jeremi merged 1 commit into
mainfrom
agent/release-source-guidance
Aug 12, 2026
Merged

docs(release): clarify protected main candidate source#732
jeremi merged 1 commit into
mainfrom
agent/release-source-guidance

Conversation

@jeremi

@jeremi jeremi commented Aug 12, 2026

Copy link
Copy Markdown
Member

Summary

  • make the accepted protected-main revision the explicit candidate and tag source
  • document the fail-closed recovery when main advances during the CI wait
  • add an exact rehearsal-run wait before opening the release PR

Why

The release CLI now revalidates protected main after waiting for CI. The operations guide still said the release-PR merge commit was unconditionally the source, which was ambiguous once main advanced.

Verification

  • python3 -m unittest release/scripts/test_release_rehearsal.py
  • git diff --check

Signed-off-by: Jeremi jeremi@users.noreply.github.com

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
@jeremi
jeremi merged commit eb20891 into main Aug 12, 2026
30 checks passed
@jeremi
jeremi deleted the agent/release-source-guidance branch August 12, 2026 14:00

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eced12977f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread release/OPERATIONS.md
--workflow release-rehearsal.yml \
--branch "${rehearsal_branch}" \
--event workflow_dispatch \
--limit 1 \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Correlate the rehearsal run before watching it

When this branch already has an earlier rehearsal and the newly dispatched run has not yet appeared in the Actions listing, --limit 1 selects that earlier run; a prior success can therefore satisfy the documented gate without testing the current branch contents and inputs. The gh run list documentation only promises to list recent filtered runs, and none of these filters identifies this dispatch uniquely. Poll for and uniquely correlate the run using its dispatch identity (such as creation time plus headSha and the input-derived display title), as the candidate-request code already does.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant