docs(release): clarify protected main candidate source - #732
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eced12977f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --workflow release-rehearsal.yml \ | ||
| --branch "${rehearsal_branch}" \ | ||
| --event workflow_dispatch \ | ||
| --limit 1 \ |
There was a problem hiding this comment.
Correlate the rehearsal run before watching it
When this branch already has an earlier rehearsal and the newly dispatched run has not yet appeared in the Actions listing, --limit 1 selects that earlier run; a prior success can therefore satisfy the documented gate without testing the current branch contents and inputs. The gh run list documentation only promises to list recent filtered runs, and none of these filters identifies this dispatch uniquely. Poll for and uniquely correlate the run using its dispatch identity (such as creation time plus headSha and the input-derived display title), as the candidate-request code already does.
Useful? React with 👍 / 👎.
Summary
mainadvances during the CI waitWhy
The release CLI now revalidates protected
mainafter waiting for CI. The operations guide still said the release-PR merge commit was unconditionally the source, which was ambiguous oncemainadvanced.Verification
python3 -m unittest release/scripts/test_release_rehearsal.pygit diff --checkSigned-off-by: Jeremi jeremi@users.noreply.github.com