Skip to content

Remove unused elh2VRE technology - #2480

Merged
simonkrogmann merged 1 commit into
remindmodel:developfrom
simonkrogmann:removeh2vre
Sep 30, 2026
Merged

simonkrogmann merged 1 commit into
remindmodel:developfrom
simonkrogmann:removeh2vre

Conversation

@simonkrogmann

@simonkrogmann simonkrogmann commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Purpose of this PR

elh2VRE is currently forced to capacity 0. Its original purposed is fulfilled by forcing elh2 capacity using q32_elh2VREcapfromTestor renamed with this PR to q32_elh2capfromTestor.

This also needs the following PRs to work:
pik-piam/mrremind#852
pik-piam/remind2#832
pik-piam/IAM-PyPSA-coupling#20

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ☑️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ☑️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

See
/p/tmp/simonkr/remind/compScen-removeh2vre-2026-09-25_16.31.49-H12.out
/p/tmp/simonkr/remind/compScen-removeh2vre-2026-09-25_16.31.49-H12.pdf

@fschreyer fschreyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks! Have you checked that this technology does not appear in the input data/reporting libraries somewhere?

Also, letting @robertpietzcker know that this technology will now be removed.

@simonkrogmann

Copy link
Copy Markdown
Contributor Author

Yes, I already created the pull requests for mrremind and remind2.

@simonkrogmann
simonkrogmann force-pushed the removeh2vre branch 2 times, most recently from a682b15 to f8f9af1 Compare September 30, 2026 15:11
@simonkrogmann
simonkrogmann merged commit 818769f into remindmodel:develop Sep 30, 2026
2 checks passed
@simonkrogmann
simonkrogmann deleted the removeh2vre branch September 30, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants