Repository navigation
Remove unused elh2VRE technology - #2480
Merged
Merged
Conversation
simonkrogmann
marked this pull request as draft
September 24, 2026 14:51
This was referenced Sep 24, 2026
simonkrogmann
marked this pull request as ready for review
September 25, 2026 15:24
fschreyer
reviewed
Sep 28, 2026
fschreyer
left a comment
Contributor
There was a problem hiding this comment.
THanks! Have you checked that this technology does not appear in the input data/reporting libraries somewhere?
Also, letting @robertpietzcker know that this technology will now be removed.
Contributor
Author
|
Yes, I already created the pull requests for mrremind and remind2. |
fschreyer
approved these changes
Sep 28, 2026
simonkrogmann
force-pushed
the
removeh2vre
branch
2 times, most recently
from
September 30, 2026 15:11
a682b15 to
f8f9af1
Compare
simonkrogmann
force-pushed
the
removeh2vre
branch
from
September 30, 2026 20:17
f8f9af1 to
0f08cde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
elh2VREis currently forced to capacity 0. Its original purposed is fulfilled by forcingelh2capacity usingq32_elh2VREcapfromTestorrenamed with this PR toq32_elh2capfromTestor.This also needs the following PRs to work:
pik-piam/mrremind#852
pik-piam/remind2#832
pik-piam/IAM-PyPSA-coupling#20
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)
See
/p/tmp/simonkr/remind/compScen-removeh2vre-2026-09-25_16.31.49-H12.out
/p/tmp/simonkr/remind/compScen-removeh2vre-2026-09-25_16.31.49-H12.pdf