Repository navigation
Wrap large includes in offlisting - #2490
Merged
Merged
Conversation
LaviniaBaumstark
approved these changes
Oct 6, 2026
LaviniaBaumstark
left a comment
Member
There was a problem hiding this comment.
nice, did you add this for all *.cs4r files?
Contributor
Author
|
No, just the largest ones. I also tried using a macro, but GAMS macros are not flexible enough. If desirable, I can add it for all cs4r/cs3r includes. |
Member
no, fine to start with teh largest ones |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Wrap every include above 100 KB in $offlisting/$onlisting. This reduces the main.lst file from ~300 MB to ~10MB. Neither full.gms nor full.lst will change through this PR.
This will help us produce less data in the future to mitigate storage issues and make it easier to work with main.lst in text editors/IDEs. (I got some out-of-memory errors on my system)
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)