Repository navigation
Decrease full.lst size - #2491
Merged
Merged
Conversation
| ' are missing. Call RSE immediately') | ||
| } | ||
| manipulateFile(dumpFilePath, list(c("$onDelim", "$offlisting\n$onDelim"), c("$offDelim", "$offDelim\n$onlisting")), fixed = TRUE) | ||
|
|
Member
There was a problem hiding this comment.
should it be deleted everywhere where it is already used?
Contributor
Author
There was a problem hiding this comment.
Unfortunately $offlisting does not get passed to the full.gms at all. The creation of full.gms removes all instances of it.
Contributor
Author
There was a problem hiding this comment.
It seems to be a side effect of dumpopt=21 here:
remind/scripts/start/prepare.R
Line 213 in aa53be6
simonkrogmann
force-pushed
the
small-full-lst
branch
from
October 7, 2026 15:37
815111a to
e91658c
Compare
LaviniaBaumstark
approved these changes
Oct 8, 2026
simonkrogmann
force-pushed
the
small-full-lst
branch
from
October 8, 2026 08:28
e91658c to
88d9b97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Automatically insert
$offlistingfor every$onDelim(and vice versa) in thefull.gmsfile. This reduces the size offull.lstfrom ~450MB to ~80MB for testOneRegi.This will help us produce less data in the future to mitigate storage issues and make it easier to work with full.lst in text editors/IDEs. (I got some out-of-memory errors on my system)
Is this desirable? Does it justify the level of hackiness?
If yes, I will make the replacement more robust before merging.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)