Repository navigation
Delete scenario_config_IKEA.csv. Project ended. - #2492
Open
dklein-pik wants to merge 2 commits into
Open
dklein-pik wants to merge 2 commits into
dklein-pik wants to merge 2 commits into
Conversation
… fail in `gamscompile` test. Deletion confirmed by Fabrice.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted obsolete configuration is fully removed without leaving references to the deleted file or scenarios.
Review effort: Balanced
Findings: None
What changed in this PR
Removes the obsolete IKEA project scenario configuration so its scenarios are no longer included in compilation tests.
Changes:
- Deletes all IKEA/NPE scenario definitions.
| File | Description |
|---|---|
config/scenario_config_IKEA.csv |
Removes the ended project’s scenario configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…d in gamscompile test, since it has been deleted earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Some of the scenarios fail in
gamscompiletest (surfacing with the weekly AMTs). Deletion confirmed by Fabrice.Type of change
Parts concerned
Impact
Checklist
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)