chore(deps): automated Go dependency update - #6036
chore(deps): automated Go dependency update#6036replicated-software-factory[bot] wants to merge 1 commit into
Conversation
|
ElasticClaw Factory seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Reviews (1): Last reviewed commit: "chore(deps): automated Go dependency upd..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| // IsPrivateImageFn is the function used by UpdateInstallationImages to determine if an image is private. | ||
| // It defaults to IsPrivateImage but can be overridden in tests to avoid network calls. | ||
| var IsPrivateImageFn = IsPrivateImage |
There was a problem hiding this comment.
If tests or callers replace IsPrivateImageFn concurrently, UpdateInstallationImages reads the shared variable from up to ten worker goroutines, causing data races or cross-test image-privacy classifications. Scope this override to an invocation or otherwise synchronize it to preserve test isolation.
Knowledge Base Used: Image Registry: Pull, Push, Copy, and Auth
- Ran go get -u ./... to refresh direct and transitive Go dependencies. - go.mod language/toolchain version bumped to 1.26.7 to satisfy github.com/bitnami/sealed-secrets v0.39.1. - helm.sh/helm/v4 upgraded to 4.2.4; updated pull/base test fixtures to match the new helm release serialization. - Fixed image privacy determinism in pull tests by injecting a mockable IsPrivateImageFn so the integration tests no longer depend on live Docker Hub privacy checks.
ff593f3 to
baa2d2c
Compare
|
Reviews (2): Last reviewed commit: "chore(deps): automated Go dependency upd..." | Re-trigger Greptile |
|
Needs rebase and is a substantial change. Closing, we can recreate another one. |
2 participants
Automated Go dependency update for the kots-update-go workflow.