test(batch): verify tags serialize in batch payloads#117
Closed
cpenned wants to merge 3 commits into
Closed
Conversation
…batch payloads Document batch email support for scheduled_at, tags, and attachments in Batch.send() javadoc. Add a serialization test to ensure these fields are included in the JSON payload sent to POST /emails/batch. Co-authored-by: cpenned <cpenned@users.noreply.github.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Confidence score: 5/5
- Safe to merge after the addressed issues were fixed.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Clarify that only tags are supported on batch emails. Attachments and scheduled_at remain unsupported. Update batch test fixtures and serialization test accordingly. Co-authored-by: cpenned <cpenned@users.noreply.github.com>
cursor
Bot
changed the title
Contributor
There was a problem hiding this comment.
0 issues found across 3 files (changes from recent commits).
Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
Co-authored-by: cpenned <cpenned@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Auto-approved: Adds Javadoc and a regression test verifying that tags are serialized in batch payloads. No behavior changes.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The batch send API supports
tagson individual emails. The Java SDK already models tags onCreateEmailOptions, whichBatch.send()reuses. This change documents that support and adds a regression test that verifies tags are included in the serialized payload.Changes
tagsinBatch.send()javadoccreateBatchEmailOption()test helper with tagstestCreateBatchEmails_SerializesTagsto assert the POST payload includes tagsTest plan
./gradlew test --tests "com.resend.services.batch.BatchTest"./gradlew testSummary by cubic
Clarify batch send behavior: only per-email
tagsare supported;attachmentsandscheduled_atare not. UpdateBatch.send()Javadoc and add a regression test verifyingtagsare included in the POST/emails/batchpayload.Written for commit 112250f. Summary will update on new commits.