Repository navigation
ToggleSpecialistMethod: name output CSVs by kind and write time only - #147
Merged
Merged
Conversation
The per-run folder already carries the run name, so repeating it in every file name and adding microseconds only lengthens paths: a reference-subsets CSV ran to 88 characters on its own and tripped tools with a path limit. Files are now <kind>_<YYYYmmdd_HHMMSS>.csv. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Second-resolution filenames can collide and silently overwrite diagnostics from rapid or concurrent runs.
1 open finding
What changed in this PR
Simplifies ToggleSpecialist CSV filenames to reduce nested path lengths.
Changes:
- Removes redundant run names from CSV filenames.
- Uses second-resolution timestamps.
- Updates test globs for the new naming scheme.
| File | Description |
|---|---|
benchmarking/baselines/toggle_specialist.py |
Simplifies output CSV names and documentation. |
tests/benchmarking/baselines/test_toggle_specialist.py |
Updates output-file matching patterns. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-run folder
toggle_specialist_<test>_<start>_<end>/already carries the run name, so repeating it in every file name and adding microseconds to the timestamp only lengthens paths: a reference-subsets CSV ran to 88 characters on its own, and a nested study tree tripped tools with a 260-character path limit. Files are now<kind>_<YYYYmmdd_HHMMSS>.csv(results_20261012_153009.csv,uncertainty_...,by_power_bin_...,data_stats_...,selection_...,reference_subsets_...).Nothing in the repo reads these files back by their old names; the four test globs are updated.
naive_ratio.pykeeps its own<run_name>_<kind>_<ts>naming, untouched here.🤖 Generated with Claude Code