chore: the six dependency bumps in one, and the code windows 0.62 needs - #22
Merged
Merged
Conversation
Dependabot's first pass opened six pull requests that step on each other: two touch Cargo.lock and two touch app/package-lock.json, so they cannot land without rebasing one another. They are applied here together against main and the lockfiles regenerated once. The majors of the Windows crates need code. windows-future 0.3 renamed get() to join() on IAsyncOperation and IAsyncOperationWithProgress — six call sites, the startup task and the three Store operations — and CI only ever reported three of them because compilation stopped at the first crate. And windows 0.62 takes a Fn where AsyncOperationProgressHandler used to take a FnMut, so the download progress callback is wrapped here rather than changing what take() asks of its caller, which genuinely needs to remember the last stage it emitted.
slint 1.18 pulls muda 0.19 through i-slint-backend-winit, so bumping tray-icon to 0.25 — which requires muda 0.20 — put both versions in the resident. On macOS each one registers the MudaMenuDelegate Objective-C class under the same name, and with LTO the link fails loading the bitcode. Windows never saw it because it has no global class registry, and neither did a debug build, because there is no LTO there. No release of slint uses muda 0.20 yet, so the two are pinned back and Dependabot is told to leave them alone until that changes. Everything else in the batch stays: the windows 0.62 bump and the code it needs are unaffected by this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot's first pass opened six pull requests that step on each other: two
touch Cargo.lock and two touch app/package-lock.json, so they cannot land
without rebasing one another. They are applied here together against main and
the lockfiles regenerated once.
The majors of the Windows crates need code. windows-future 0.3 renamed get() to
join() on IAsyncOperation and IAsyncOperationWithProgress — six call sites, the
startup task and the three Store operations — and CI only ever reported three of
them because compilation stopped at the first crate. And windows 0.62 takes a Fn
where AsyncOperationProgressHandler used to take a FnMut, so the download
progress callback is wrapped here rather than changing what take() asks of its
caller, which genuinely needs to remember the last stage it emitted.