fix: the documents say what the program does - #26
Merged
Merged
Conversation
PRIVACY promised that explorer, cmd and powershell are discarded as the origin of a link. They are not, and they should not be: a rule that sends everything coming from the shell to one browser is a choice, and the picker already names the rule that decided. The document now describes what happens instead of what somebody once thought should. The theme started dark while the language already followed the system, so a fresh install on a light desktop opened dark — and the settings window painted a dark first frame before the backend answered. Both follow the system now. The README claimed rule order decides. It cannot: upsert replaces any rule with the same scope and origin, so two never coexist and the most precise one wins. ruleUp and ruleDown translated a button that does not exist, and the English build-tree notice had lost the sentence that says the copy does not register.
There were no design tokens: every component wrote its own hex, so the same five colours appeared 26, 21, 21, 20 and 20 times across six files and changing the blue meant forty-two edits. index.css now carries the palette in :root with a full dark counterpart, and the pieces About is made of — the brow, the what-is block, badges, the support rows, the tool rows, the update card, the progress bar and the alarms — are classes that read from it. About is also rebuilt with the anatomy the sibling project already uses: a badge in a gradient of the accent rather than a flat square, an eyebrow over the block that says what the program is, and icons in the four claims. Not one system colour is left hardcoded on that page; the six that remain are brand colours and have to be. The shared parts.tsx is untouched, so the other five pages keep working as they did. They are what moves next.
…again The first image on the project page was resources/assets/icon_128.png — the 2.0 icon, replaced since and used nowhere else. The README now points at the one the app installs, and nothing references the old one any more. And moving the support rows from Tailwind's truncate to a class of their own kept overflow and text-overflow but dropped white-space: nowrap, without which an ellipsis does nothing: a long host would have wrapped onto a second line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRIVACY promised that explorer, cmd and powershell are discarded as the origin
of a link. They are not, and they should not be: a rule that sends everything
coming from the shell to one browser is a choice, and the picker already names
the rule that decided. The document now describes what happens instead of what
somebody once thought should.
The theme started dark while the language already followed the system, so a
fresh install on a light desktop opened dark — and the settings window painted
a dark first frame before the backend answered. Both follow the system now.
The README claimed rule order decides. It cannot: upsert replaces any rule with
the same scope and origin, so two never coexist and the most precise one wins.
ruleUp and ruleDown translated a button that does not exist, and the English
build-tree notice had lost the sentence that says the copy does not register.