Skip to content

ci: commit subjects may run to 100 characters, PR number included #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgdevment merged 1 commit into from
Oct 4, 2026
Merged

ci: commit subjects may run to 100 characters, PR number included #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/commits.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
TITLE: ${{ github.event.pull_request.title }}
NUMBER: ${{ github.event.pull_request.number }}
run: |
fits() { [ "$(printf '%s (#%s)' "$1" "$NUMBER" | wc -m)" -le 90 ]; }
fits() { [ "$(printf '%s (#%s)' "$1" "$NUMBER" | wc -m)" -le 100 ]; }
short=$(printf '%s' "$TITLE" | sed -E 's/ across [0-9]+ director(y|ies)//')
fits "$short" || short=$(printf '%s' "$short" | sed -E 's/ from [^ ]+ to [^ ]+//')
fits "$short" || short=$(printf '%s' "$short" | sed -E 's/^([a-z]+: bump) .* in the ([^ ]+) group.*/\1 the \2 group/')
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ application and dies with the console it was started from.
### Commits and the checks that run before them

Subjects follow [Conventional Commits](https://www.conventionalcommits.org/)
(`feat:`, `fix:`, `docs:`, `ci:`…), under 90 characters: CI refuses a longer one,
(`feat:`, `fix:`, `docs:`, `ci:`…), under 100 characters: CI refuses a longer one,
and a squash keeps only the pull request's title, number included, so that is
held to the same shape.

Expand Down
2 changes: 1 addition & 1 deletion scripts/commits.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -uo pipefail

shape='^(feat|fix|docs|style|refactor|perf|test|build|ci|chore|revert)(\([a-z0-9._-]+\))?!?: .+'
most=90
most=100
status=0

amiss() {
Expand Down
Loading