fix: a UserChoice naming a class that is gone no longer counts as default - #46
Merged
Merged
Conversation
…ault Uninstalling the installer copy removes LinkUnboundURL from the classes, but UserChoice keeps naming it: Windows guards that key with a hash and no application may rewrite it. The Store copy then reported itself as the default browser while every https link opened "Choose an app". A ProgId now counts as held only when it is ours and its class still opens under HKEY_CLASSES_ROOT, for is_default_browser and association_report alike.
The hooks, the PR title check and the guide all read the same ceiling.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uninstalling the installer copy removes
LinkUnboundURLfrom the classes, butUserChoicekeeps naming it: Windows guards that key with a hash and no application may rewrite it. The Store copy then reported itself as the default browser while everyhttpslink opened "Choose an app".A ProgId now counts as held only when it is ours and its class still opens under
HKEY_CLASSES_ROOT, foris_default_browserandassociation_reportalike.a_user_choice_naming_a_class_that_is_gone_is_not_held-D warnings,scripts/rules.sh