feat: the third-party notices travel inside the app - #47
Merged
Merged
Conversation
About used to send people to THIRD-PARTY-BUNDLED.md on GitHub, so a copy without network, or one from the Store, never carried the notices that MIT, Apache, BSD and ISC ask to go with it. The binary now includes the file and About unfolds it, drawn with markdown-it (html off) and with its links handed to the system browser. The about command moves to its own module with notices beside it, which keeps lib.rs under its ceiling. markdown-it brings seven packages into the notices.
A second click while the first read was still on its way sent another request, and both answers opened the panel. A failed read went to the alert at the top of About, out of sight of the button at the bottom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About used to send people to THIRD-PARTY-BUNDLED.md on GitHub, so a copy without network, or one from the Store, never carried the notices that MIT, Apache, BSD and ISC ask to go with it. The binary now includes the file and About unfolds it, drawn with markdown-it (html off) and with its links handed to the system browser.
The about command moves to its own module with notices beside it, which keeps lib.rs under its ceiling. markdown-it brings seven packages into the notices.