Skip to content

A few bug fixes for kdump utils tests#159

Open
liutgnu wants to merge 4 commits into
rhkdump:mainfrom
liutgnu:test
Open

A few bug fixes for kdump utils tests#159
liutgnu wants to merge 4 commits into
rhkdump:mainfrom
liutgnu:test

Conversation

@liutgnu

@liutgnu liutgnu commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

This patchset contains 4 patches:

4 tests: Update the default ssh/nfs dump server
3 tests: Copy ssh client's pubkey to ssh server
2 tests: Restart the nfs-server service after "systemctl enable --now"
1 tests: Update the url of ovs configure script

1 & 4 are fixes on outdated info.
2 & 3 are fixes on bugs I have encountered.

To run the local tests:
$ tools/build-rpm.sh 44
/root/kdump-utils/x86_64/kdump-utils-1.0.62-1.fc44.x86_64.rpm
$ cd tests
$ tmt run --environment KDUMP_UTILS_RPM="/root/kdump-utils/x86_64/kdump-utils-1.0.62-1.fc44.x86_64.rpm" -a

liutgnu added 4 commits July 17, 2026 15:33
The old url link is no longer accessible. The machine-config-operator
repo now uses "main" instead of "master" as its default branch. This
patch will update the url link of the ovs configure script to follow
up the branch modification, otherwise the nfs-ovs testing will fail.

Signed-off-by: Tao Liu <ltao@redhat.com>
A nfs mount hang is observed during nfs testing in the client side:

  [root@client ~]# mount 192.168.122.17:/var/tmp/nfsshare /mnt
  <<------- hang

After restarting the nfs-server service in the server side, the nfs client
mount can exit successfully in a short time:

  [root@server ~]# systemctl restart nfs-server
  [  430.828865] NFSD: Using nfsdcld client tracking operations.
  [  430.837690] NFSD: no clients to reclaim, skipping NFSv4 grace period (net effffff9)

The root cause is unclear, but a service restart can bypass it. This
patch will introduce the mitigation.

Signed-off-by: Tao Liu <ltao@redhat.com>
Without the patch, when ssh client trying to login to server, it will require
a password typein, which is impossible during automatic test, thus test
fails.

The patch fix this by copying the ssh client's pubkey into the server at
the server setup stage, which is ahead of ssh client setup stage as
defined in ssh.fmf.

Signed-off-by: Tao Liu <ltao@redhat.com>
The pek server is no longer accessible, redirect it to bos.

Signed-off-by: Tao Liu <ltao@redhat.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates test plans and setup scripts, including adding an SSH server setup step, refactoring the SSH network client setup to handle server and client IP logic, restarting the NFS server after enabling it, updating a URL branch from master to main, and changing the AUTO_CONFIG environment variable to bos. Feedback was provided to ensure that the /root/.ssh directory is created with the correct permissions (700 for the directory and 600 for authorized_keys) to prevent potential setup failures on minimal systems.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/setup/network_client/test.sh
@liutgnu
liutgnu requested a review from coiby July 18, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant