Skip to content

ci(pipboy): add rust dependency hygiene - #360

Merged
eersnington merged 3 commits into
stack/ci-ci-insights-add-package-footprint-tmymzrrkfrom
stack/ci-ci-insights-add-rust-dependency-hygiene-xpkxwlto
Oct 21, 2026
Merged

eersnington merged 3 commits into
stack/ci-ci-insights-add-package-footprint-tmymzrrkfrom
stack/ci-ci-insights-add-rust-dependency-hygiene-xpkxwlto

Conversation

@eersnington

@eersnington eersnington commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Add pipboy hygiene. It runs cargo deny and cargo shear in sandbox-agent/ on the merge base and the PR, then diffs the findings. Neither tool compiles anything.

  • Fail only on new findings in advisories, licenses, and sources. Bans and unused dependencies are reported only. Existing findings never fail a PR.
  • Finding keys leave out the crate version, so a routine bump of an already flagged crate is not new.
  • Add sandbox-agent/deny.toml with the license allow-list from rivet-dev/rivet.
  • Run only when Rust files, Cargo.*, or deny.toml under sandbox-agent/ change.
pnpm --filter pipboy pipboy hygiene --base-root ../base --out hygiene.json

This is part 2 of 4 in a stack:

@eersnington
eersnington marked this pull request as ready for review October 20, 2026 08:20
@eersnington
eersnington force-pushed the stack/ci-ci-insights-add-rust-dependency-hygiene-xpkxwlto branch from 843a5d3 to 968a51d Compare October 20, 2026 08:20
@eersnington
eersnington force-pushed the stack/ci-ci-insights-add-package-footprint-tmymzrrk branch from 1abb628 to 45609c6 Compare October 20, 2026 08:20
@eersnington eersnington changed the title ci(ci-insights): add rust dependency hygiene ci(pipboy): add rust dependency hygiene Oct 20, 2026
@rivet-dev rivet-dev deleted a comment from github-actions Bot Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

📟 Pip-Boy · 0c72293

📦 Packages · fresh npm install resolve, no lockfile · this PR vs base

No notable install size, dependency, or entrypoint changes across 10 packages.

All 10 packages · linux-x64-gnu
package (linux-x64-gnu) @latest base this PR Δ vs base packages
@rivet-dev/pi 428.6 MB 428.6 MB 428.6 MB 0 215 (0)
@rivet-dev/sandbox-adapter 75.0 MB 75.0 MB 75.0 MB 0 92 (0)
@sandbox-agent/cli-shared 27.2 KB 27.2 KB 27.2 KB 0 1 (0)
@sandbox-agent/persist-indexeddb 12.4 KB 12.4 KB 12.4 KB 0 1 (0)
@sandbox-agent/persist-postgres 12.3 KB 12.3 KB 12.3 KB 0 1 (0)
@sandbox-agent/persist-rivet 12.2 KB 12.2 KB 12.2 KB 0 1 (0)
@sandbox-agent/persist-sqlite 12.3 KB 12.3 KB 12.3 KB 0 1 (0)
@sandbox-agent/react 41.5 MB 41.8 MB 41.8 MB 0 15 (0)
acp-http-client 6.7 MB 6.7 MB 6.7 MB 0 3 (0)
sandbox-agent 30.9 MB 31.0 MB 31.0 MB 0 8 (0)

🧹 Rust dependencies · cargo deny + cargo shear

check new in this PR fixed existing on base
advisories ✅ 0 0 14
licenses ✅ 0 318 0
sources ✅ 0 0 0
bans ✅ 0 0 0
unused ✅ 0 0 13

🦀 Binaries · publish Dockerfiles, --release

No native build on main to compare against yet.

artifact npm @latest base this PR Δ vs base
gigacode linux-x64 23.6 MB — 23.6 MB —
sandbox-agent linux-x64 23.6 MB — 23.5 MB —

⏱ Timing

job wall time slowest step
zizmor 14s checkout · 8s
changes 17s checkout · 13s
footprint 2m16s Pack the base · 30s
native · linux-x64 3m22s Build with the release script · 2m22s
hygiene 46s setup-node · 14s
self-test 45s setup-node · 15s
report 33s setup-node · 16s
🔭 Full CI trace for this commit

One OpenTelemetry trace of CI and Pip-Boy for 0c72293: every job and step, with the sizes above attached. Run after CI finishes.

pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha 0c722937e1a4e263701e2217a27b73c6af0618e4

Add --otlp <url> to send it to any OTLP/HTTP collector.

Agent instruction: From a rivet-dev/agents checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.

@eersnington
eersnington force-pushed the stack/ci-ci-insights-add-rust-dependency-hygiene-xpkxwlto branch from 968a51d to 58664cc Compare October 20, 2026 08:36
@eersnington
eersnington force-pushed the stack/ci-ci-insights-add-package-footprint-tmymzrrk branch from 45609c6 to ca844af Compare October 20, 2026 08:36
@eersnington
eersnington merged commit 88f6654 into stack/ci-ci-insights-add-package-footprint-tmymzrrk Oct 21, 2026
5 checks passed
@eersnington
eersnington deleted the stack/ci-ci-insights-add-rust-dependency-hygiene-xpkxwlto branch October 21, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant