feat(inspector-tabs): send resolved theme tokens and mounted surface to custom tab iframes - #5501
feat(inspector-tabs): send resolved theme tokens and mounted surface to custom tab iframes#5501jog1t wants to merge 1 commit into
Conversation
…to custom tab iframes
|
🚅 Deployed to the rivet-pr-5501 environment in rivet-frontend
|
ReviewSolid, well-scoped feature: resolved theme tokens + mounted-surface info are added to the existing A few minor things worth a look, nothing blocking: 1. Misleading diagnostic message ( 2. Duplicated "card" surface constant across the package boundary 3. 4. Example inline 5. Test coverage Nothing here blocks merging — mostly small robustness/consistency nits for a change that's otherwise clean and backward-compatible. |
initpostMessage, astokens(ready-to-use CSS color values) plussurface, which names the token of the panel the tab is mounted on.themeis unchanged, so tabs that only read it keep working.--rivet-surface(the mounted surface, aliasing--rivet-card) and paintshtml/bodywith it instead of--rivet-background. This alone makes existing tabs sit flush in their host panel with no tab-side change.applyInspectorTabTheme,resolveInspectorTabSurface, andinspectorTabTokenVarhelpers torivetkit/inspector-tabfor tabs built with a bundler.Verified against the generated stylesheet and real theme tokens in a harness reproducing the dashboard's
cardpanel: the tab body computes to the same color as its host panel in dark (rgb(12,12,14)) and light (rgb(255,255,255)), updates on theme toggle without reloading, and a theme-only tab with no token handling measures identically.