Repository navigation
Fix #23: namespace-qualify DBI calls with pool:: - #26
Merged
Merged
Conversation
Several DBI generics (dbGetQuery, dbExecute, dbWriteTable) were called without a namespace prefix, causing 'could not find function' errors when DBI/pool is not attached to the search path. Qualify all such calls with pool::, matching the pattern used elsewhere in the package. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #23.
Several DBI generics (
dbGetQuery,dbExecute,dbWriteTable) were called without a namespace prefix. WhenDBI/poolisn't attached to the search path, these resolve to nothing and produce errors like:DBIisn't even listed in the packageDepends/Imports, so relying on it being attached is fragile. This PR qualifies all such calls withpool::, matching the pattern already used elsewhere in the package (e.g.create_database_tables.R,drop_database_tables.R,fun-timeranges.R).Changes
Qualified 8 call sites across 6 files:
R/doc_exists.RdbGetQuery→pool::dbGetQueryR/fun-db.RdbWriteTable, 2×dbExecute,dbGetQueryR/add_doc.RdbExecute→pool::dbExecuteR/get_doc.RdbGetQuery→pool::dbGetQueryR/insert_location_info.RdbExecute→pool::dbExecuteR/remove_doc.RdbExecute→pool::dbExecuteNo
DESCRIPTION/NAMESPACEchanges needed —poolis already a dependency.Testing
Could not run the testthat suite locally (no R toolchain available in the environment). The change is mechanical and consistent with existing working code; the
R-CMD-checkworkflow will exercise the full test suite on this PR.