Repository navigation
Conversation
Issue21, improve error catching
Several DBI generics (dbGetQuery, dbExecute, dbWriteTable) were called without a namespace prefix, causing 'could not find function' errors when DBI/pool is not attached to the search path. Qualify all such calls with pool::, matching the pattern used elsewhere in the package. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jspijker
marked this pull request as draft
August 27, 2026 08:40
Fix #23: namespace-qualify DBI calls with pool::
Closes #25 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add list_doc() to list meta document references by type
The cache table now stores a non-nullable time_dl field recording when a time range was inserted. insert_time_range fills it with the current time as a UTC unix timestamp. Closes #29 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add time_dl timestamp to cache table
Add a function to remove measurements based on their download time, recorded in the cache table's time_dl field. For every cached time range downloaded before the given date, the measurements of the station between the range start and end (inclusive) are removed. When no measurements for a station remain, the station is also removed from the location table. The processed cache record is removed and a named list describing the removed ranges is returned. Includes a roxygen2 header, generated documentation, testthat tests and a new "Remove data" chapter in the vignette. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Make the cutoff inclusive: select cached ranges with time_dl <= date and update the roxygen header wording accordingly. - Update the vignette "Remove data" chapter to say "before or equal to". - Move the seed_ test helpers into tests/testthat/helper.R and add a test for a range downloaded exactly at the cutoff. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add remove_time_ranges_before function (issue #30)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.