Repository navigation
fix: pin Linux packaging sources to LF so AUR digests match on Windows - #3
Merged
Merged
Conversation
The AUR generator hashes the desktop entry and udev rules as working-tree bytes. With no .gitattributes, the Windows runner checked them out CRLF, so the rendered PKGBUILD digests diverged from the goldens and Test · Windows failed on every CI run since f5cf464. Pin *.desktop, *.rules, *.sh, and packaging/linux/AppRun to LF. The FFmpeg-removal guard listed .gitattributes as a removed path only because its single rule was the FFmpeg manifest rule. Drop that existence assertion; the token guard over .gitattributes is unchanged and still fails when the retired token is reintroduced. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Test · Windowshas failed on every completed CI run onmainsincef5cf464(2026-08-08). Two tests fail, both intests/test_package_managers.py:AurGeneratorTests.test_pkgbuild_and_srcinfo_match_goldensAurGeneratorTests.test_generate_aur_package_writes_treeThe AppImage and installer builds were not affected.
Cause
The AUR generator hashes
packaging/linux/am-configurator.desktopandam_configurator/data/60-am-neon-80.rulesas working-tree bytes. The repo had no.gitattributes, so the Windows runner checked those files out with CRLF and the digests in the renderedPKGBUILDno longer matched the goldens.Change
.gitattributespinning*.desktop,*.rules,*.sh, andpackaging/linux/AppRunto LF.tests/test_packaging.pythat.gitattributesmust not exist. It was listed as a removed path only because its single rule was the FFmpeg manifest rule. The guard that fails when the retired token appears in.gitattributesis unchanged..agents/state.md.Verification
core.autocrlf=trueclone of4cf4d13: the same 2 tests fail with the same digests as CI. With.gitattributesadded, all 21 tests in the module pass..gitattributesfailstest_current_surfaces_have_no_retired_media_tool_reference.node --checksteps, anduv buildpass.🤖 Generated with Claude Code