Skip to content

Optionally exclude the region from being included in the gamelist game name - #266

Closed
PixNyb wants to merge 4 commits into
rommapp:mainfrom
PixNyb:feat/gamelist-improvements
Closed

PixNyb wants to merge 4 commits into
rommapp:mainfrom
PixNyb:feat/gamelist-improvements

Conversation

@PixNyb

@PixNyb PixNyb commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

also fixes typo

@pawndev

pawndev commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

The default behavior will change like that no ? It'll be disable for everyone by default

@PixNyb

PixNyb commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

I can swap around the logic or set a true as default if you like

@pawndev

pawndev commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

I'd rather not break any existing installation/behavior for the end user, so yeah if we could set it to true by default

@BrandonKowalski

Copy link
Copy Markdown
Member

Thanks @PixNyb! I pulled this onto a big refactor I've been working on, so it went in as its own commit with you as the author. One change: the setting is stored as gamelist_omits_region now, since with omitempty a default of true meant false never got saved. It's on dev and goes out with the next release, so I'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants