Add "Download missing" action to the platform list - #271
Open
nixxou wants to merge 1 commit into
Open
Conversation
R1 on a focused platform in the home list downloads every game of that platform that isn't on the device yet: it gathers the not-downloaded games, asks for confirmation, then reuses the existing download pipeline (DownloadScreen -> DownloadManager), so progress, cancel, artwork and unzip handling all come for free. - Hidden in kid mode. - No per-row work on the platform list; the missing set is computed only when R1 is pressed, so the home screen keeps its current load cost. - New ui.DownloadMissingForPlatform helper + missingGames, unit tested. - Parameterised strings use %d/%s + fmt.Sprintf (as bios_download.go does) so they render even before the locale catalogs are updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Download missing action to the home platform list. With a platform focused, R1 downloads every game of that platform that isn't on the device yet.
Download N missing game(s) for X?DownloadScreen→DownloadManager, so the progress modal, cancel, and artwork/unzip/gamelist handling are all reusedDownloaded N of M game(s).Why
Today you can only download one game at a time, or hand-pick a multi-selection in the game list. "Give me everything new for this system" means a lot of scrolling and tapping; this is one gesture from the screen you're already on.
Notes / decisions
R1viaTertiaryActionButton— free on this screen and present on Miyoo (Selectis taken by reorder).active.en.tomlupdated. Parameterised strings use%d/%s+fmt.Sprintf(same asui/bios_download.go) so they render correctly even for locales that haven't picked up the new keys yet. Happy to runtask i18n/ addtranslations_todoentries if you'd prefer that in-PR.executeMultiDownloadUI/executeDownloadUIinapp/helpers.go, action enum + transition case inapp/transitions.go.Testing
go build ./..., cross-compiled for muOS (arm64) via Docker — greengo test ./ui/...— newTestMissingGames(single-file / multi-file / missing-slug)Per the contributing guide I'm happy to take the UX discussion to Discord first (key choice, whether this also belongs on the collection→platform screen) — just let me know.