Document the depth-first pre-order of ReportIter as a guarantee - #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iteration order of
ReportIterwas described informally at each entry point but never stated as a contract. This PR makes depth-first pre-order an explicit guarantee, documented once onReportIterwith an order-asserting example on a branching tree, and thins theiter_reports/iter_sub_reports/iter_downcast_contextdocs to reference it (per the revised style guide's push-shared-explanation-up rule).Users writing first-match searches (e.g.
iter_downcast_context::<D>().next()) can now rely on the order.