Skip to content

update msvc 2022 version to be similar to doc - #888

Open
knmcguire wants to merge 1 commit into
masterfrom
knm/update-msvc
Open

update msvc 2022 version to be similar to doc#888
knmcguire wants to merge 1 commit into
masterfrom
knm/update-msvc

Conversation

@knmcguire

@knmcguire knmcguire commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Updates MSVC 2022 to be similar to the current rolling source install documentation.

It builds fine on my end.

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

@mergify

mergify Bot commented Aug 3, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@knmcguire

knmcguire commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

Trying it out on ci-windows now

Build Status

(I think there are issues with disk space on the runners right now so might need to redo it)

@knmcguire

Copy link
Copy Markdown
Collaborator Author

Let's try it again

Build Status

@knmcguire

knmcguire commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

Build Status

@knmcguire

Copy link
Copy Markdown
Collaborator Author

So to me it seems that the build passes but the amount of failed test still indicates it as a failure... but these amount of failures also exist in other CI so not sure what to do here

perhaps wait until the tests are back to a reasonable amount?

@fgallegosalido

Copy link
Copy Markdown
Contributor

@knmcguire most of those tests have already been fixed as part of ros2/rmw_connextdds#250. Give it another try and see how it goes.

@knmcguire

knmcguire commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks! It's weird how it would sometimes detect it as a failure at the same level of failed tests and then sometimes it is just unmarked as unstable. There might be other things in the pipeline that went wrong.

Anyway! Just running it one more time

Build Status

Retry:
Build Status

Retry:
Build Status

(starting to think if this MSVC version is causing the long build times...)

@knmcguire

Copy link
Copy Markdown
Collaborator Author

Finally... the last build succeeded with only 34 failed tests

Any ci ran with colcon test with --executor sequential just takes way too long... lesson for next time!

@mjcarroll is it okay for me to merge this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants