update msvc 2022 version to be similar to doc - #888
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
|
So to me it seems that the build passes but the amount of failed test still indicates it as a failure... but these amount of failures also exist in other CI so not sure what to do here perhaps wait until the tests are back to a reasonable amount? |
|
@knmcguire most of those tests have already been fixed as part of ros2/rmw_connextdds#250. Give it another try and see how it goes. |
|
Thanks! It's weird how it would sometimes detect it as a failure at the same level of failed tests and then sometimes it is just unmarked as unstable. There might be other things in the pipeline that went wrong. Anyway! Just running it one more time (starting to think if this MSVC version is causing the long build times...) |
|
Finally... the last build succeeded with only 34 failed tests Any ci ran with colcon test with --executor sequential just takes way too long... lesson for next time! @mjcarroll is it okay for me to merge this now? |
Description
Updates MSVC 2022 to be similar to the current rolling source install documentation.
It builds fine on my end.
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information