Skip to content

Fix broken Linux command-line guide link - #6929

Merged
fujitatomoya merged 1 commit into
ros2:rollingfrom
dlanov:fix-beginner-workspace-linux-guide-link
Aug 31, 2026
Merged

Fix broken Linux command-line guide link#6929
fujitatomoya merged 1 commit into
ros2:rollingfrom
dlanov:fix-beginner-workspace-linux-guide-link

Conversation

@dlanov

@dlanov dlanov commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR improves the Linux command-line prerequisite in the Creating a Workspace tutorial.

Based on maintainer feedback, the existing SFU Unix/Linux guide is retained and the Ubuntu beginner command-line guide is added as an alternative.

Changes

  • Keeps the existing SFU Unix/Linux command-line guide.
  • Adds Ubuntu's Linux command-line beginner guide as an alternative.
  • Presents both resources as choices under the terminal-command prerequisite.

Testing

I ran:

  • make html
  • make lint
  • make spellcheck
  • git diff --check

The documentation build succeeded, lint reported no problems, spellcheck passed, and git diff --check returned no issues.

Part of #4209.

AI assistance disclosure

I used Claude Code to help prepare the documentation change, then manually reviewed the diff and test results before submitting.

@dlanov

dlanov commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

I updated the replacement link to use the newer Ubuntu Desktop documentation URL.

I re-ran:

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www2.cs.sfu.ca/~ggbaker/reference/unix/ seems working with no problems for me, what is the problem on this site? and this PR needs rebase.

@sloretz

sloretz commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Thank you for the PR!

  • Please resolve the merge conflict
  • It looks like the existing link works, but I think we don't have much of an opinion on who teaches someone about the linux command line. Would you be willing to turn this into a bulleted list with both links? That way if one goes down, the reader can choose the other one.

@ahcorde

ahcorde commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

friendly ping @dlanov

@dlanov

dlanov commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the ping, and sorry I missed the earlier feedback. I'll rebase the branch, resolve the conflict, and update the prerequisite to keep both the existing SFU guide and the Ubuntu command-line guide as alternatives.

Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
@dlanov
dlanov force-pushed the fix-beginner-workspace-linux-guide-link branch from 6afabaa to f54287a Compare August 28, 2026 14:49
@dlanov

dlanov commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback. I've rebased the branch onto the latest rolling and updated the prerequisite to keep both the existing SFU guide and the Ubuntu guide as alternatives. I also re-ran the HTML build, lint, spellcheck, and diff checks.

@fujitatomoya
fujitatomoya merged commit ebe356a into ros2:rolling Aug 31, 2026
6 checks passed
@fujitatomoya fujitatomoya added the backport-all backport at reviewers discretion; from rolling to all versions label Aug 31, 2026
ahcorde pushed a commit that referenced this pull request Aug 31, 2026
(cherry picked from commit ebe356a)

Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
Co-authored-by: Dennis Lanov <155569926+dlanov@users.noreply.github.com>
fujitatomoya pushed a commit that referenced this pull request Aug 31, 2026
* Add alternative Linux command-line guide (#6929)

Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
(cherry picked from commit ebe356a)

# Conflicts:
#	source/Tutorials/Beginner-Client-Libraries/Creating-A-Workspace/Creating-A-Workspace.rst

* Fixed merge

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Dennis Lanov <155569926+dlanov@users.noreply.github.com>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
fujitatomoya added a commit that referenced this pull request Aug 31, 2026
* Add alternative Linux command-line guide (#6929)

Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
(cherry picked from commit ebe356a)

# Conflicts:
#	source/Tutorials/Beginner-Client-Libraries/Creating-A-Workspace/Creating-A-Workspace.rst

* Fixed merge

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Dennis Lanov <155569926+dlanov@users.noreply.github.com>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Tomoya Fujita <fujita.tomoya@triorb.co.jp>
fujitatomoya added a commit that referenced this pull request Aug 31, 2026
* Add alternative Linux command-line guide (#6929)

Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
(cherry picked from commit ebe356a)

# Conflicts:
#	source/Tutorials/Beginner-Client-Libraries/Creating-A-Workspace/Creating-A-Workspace.rst

* Fixed merge

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Dennis Lanov <155569926+dlanov@users.noreply.github.com>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Tomoya Fujita <fujita.tomoya@triorb.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants