Add notification about the usage of <rclcpp/rclcpp.hpp>. (backport #7113) - #7144
Merged
Conversation
Signed-off-by: Tomoya Fujita <fujita.tomoya@triorb.co.jp> Signed-off-by: Katherine Scott <katherineAScott@gmail.com> Co-authored-by: Katherine Scott <katherineAScott@gmail.com> (cherry picked from commit e8142b2) # Conflicts: # source/ROS-Framework/client-libraries/Working-with-Client-Libraries/Single-Package-Define-And-Use-Interface.rst
Contributor
Author
|
Cherry-pick of e8142b2 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
The mergify backport of #7113 assumed rolling's directory layout, where the client-library tutorials were moved under ROS-Framework/client-libraries/Working-with-Client-Libraries/. On kilted those files still live at their older, shallower locations, so the backport was broken in two ways: - It re-added Single-Package-Define-And-Use-Interface.rst under the rolling-only path. That file already exists at How-To-Guides/ on this branch, so the copy was an orphan (not in any toctree) with dangling cross-references and failed the build. Removed it. - Every ".. include::" of the convenience-header note used a relative path computed for rolling's deeper tree, so it overshot the source root on kilted and the note file could not be found (failing both the Sphinx build and doc8). Recomputed each include to the correct relative depth for its own location. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Tomoya.Fujita <fujita.tomoya@triorb.co.jp>
fujitatomoya
approved these changes
Aug 31, 2026
Collaborator
|
@ahcorde requesting your approval since i resolved some conflicts. |
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/33392008896/artifacts/9757980496. To view the resulting site:
|
ahcorde
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #7095
Fixes # (issue)
Did you use Generative AI?
Yes, Claude Fable 5
Additional Information
This is an automatic backport of pull request #7113 done by [Mergify](https://mergify.com).