Repository navigation
feat: refine demo themes and keep chart active beside settings - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the demo theme selector to the top-right header and refine the dark appearance with neutral surfaces, restrained colors, and simpler controls.
On desktop, Chart settings opens beside the chart with matching height. Zoom and markers remain active while the rest of the page is strongly dimmed and inert. Settings scroll internally when needed. Smaller screens retain a modal dialog, and changing viewport size switches modes without losing settings.
Clicking or tapping the dimmed background, Escape, and Close dismiss settings and restore focus to the opener. Clicking the chart or dragging out of the settings panel keeps settings open.
Align neighboring desktop panels in both rows. Apply the same graphite palette, typography, controls, borders, and spacing to the example gallery and every example, including the independently runnable basic consumer. Preserve explicit white hosts for light library charts.
Validation:
npm run lint:fix,npm run format, andnpm run checkpassed (465 unit tests).