Repository navigation
Group visual configuration and allow mounting in the Smith constructor - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual configuration mixed text, line, cursor, and marker settings into flat objects. Group these properties by element, so a grid text override is now
grid.style.text.colorand a theme override isappearance.overrides.grid.text.color. Nested layer patches retain omitted properties, with complete validation before mutation. Theme replacement semantics and existing visual/interaction defaults stay the same. Q and VSWR theme widths can be set independently.Add
new Smith(target, options?)for immediate mounting with a CSS selector or HTMLElement, including elements from another window. Keepnew Smith(options)plusdraw()for deferred mounting. The mounting target remains separate fromSmithOptions, and failed constructor mounts clean up observers and renderer resources.This is a breaking change for the next minor release: flat visual style keys are removed. Update the demo, examples, API signature report, configuration reference, README, and migration guide together.
Validation:
npm run lint:fix,npm run format, andnpm run check(470 unit tests).npm run check:package: installed ESM runtime, NodeNext/Bundler declarations including TypeScript 5.7.3, and 23 README/guide snippets.npm run check:example: installed gallery, React/Angular integrations, updates, resize, and cleanup in all three browser engines.