Repository navigation
Simplify Touchstone import using the file reference - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Touchstone example now configures the chart with the reference impedance read from the file. Remove the reference selector and renormalization step so loading and exporting a measurement preserves its original data and reference. Parameter changes update the existing trace.
Use a 75 Ω fixture to demonstrate reading a non-default file reference, update gallery descriptions and the guide, and link intentional reference conversion to the separate RF documentation. The library implementation and public API are unchanged.
Validation: Prettier, ESLint,
npm run check(470 unit tests),npm run test:e2e(132 browser tests), andnpm run check:packageincluding 24 documentation snippets. The browser test verifies S22 selection and unchanged values in a 75 Ω export.