Skip to content

feat(ase-code-review): add skill to review and curate uncommitted changes into commits - #84

Open
Brusdeylins wants to merge 1 commit into
rse:masterfrom
Brusdeylins:add-review-skill
Open

Brusdeylins wants to merge 1 commit into
rse:masterfrom
Brusdeylins:add-review-skill

Conversation

@Brusdeylins

Copy link
Copy Markdown
Collaborator

What

Adds a new skill ase-code-review which reviews an accumulated pile of uncommitted
changes and curates them into clean, thematically coherent commits on the current
branch -- group by group, each committed only on the user's explicit accept.

It closes a gap between the existing version-control skills: ase-meta-diff narrates
what changed, ase-meta-review judges an already staged diff, ase-meta-commit
crafts the message -- but nothing helps turn a large, mixed working tree into a
sequence of reviewed commits. ase-code-review curates and commits, and delegates to
those neighbours instead of duplicating them.

How it works

  • Grouping: every hunk of working tree, index, and untracked files is mapped to 3-5
    themes (FEATURE, BUGFIX, REFACTOR, UPDATE, CLEANUP, IMPROVEMENT -- the taxonomy shared
    with ase-meta-commit/ase-meta-diff), ordered for comprehension (foundations first,
    no forward references). The user confirms the cut from one compact table; that
    single dialog also carries the mode switches.

  • Modes: HORIZONTAL (default) groups by topical proximity and runs no build;
    VERTICAL cuts build-safe slices and gates every accept on a green build.
    TESTS-LAST (default) keeps test hunks in one final group; REVIEW-TESTS lets them
    join the code they cover.

  • Index-only staging: one group at a time is staged into the plain Git index -- no
    work branch, no git stash, no diff dumps. The staged set is verified against the
    plan, and the user reviews the actual lines in their own editor.

  • Group card: a boxed card per group with a rationale and, per file, a
    plain-language before → after explanation, the touched symbols, and five evidence
    lines (DOMAIN, ARCH, CLEAN, PERF, TESTS). Each carries an honest status:
    only with a verbatim file:line citation, with the exposing case and the
    cheapest repair, ? when execution would be needed, for n/a. A single flips
    the recommended answer from ACCEPT to CHANGE.

  • Outcomes: ACCEPT commits via ase-meta-commit; CHANGE implements the demanded
    correction via ase-code-edit (mode derived from the wish) and re-presents the group;
    DISCUSS, SKIP, REGROUP, and CANCEL never discard working-tree content.

  • Constraints: read-only tool allowlist for Git (status, diff, show, log,
    grep, ls-files); dialogs follow the ASE custom-dialog convention with exactly one
    recommended option; boxed output is pre-wrapped at 96 columns; CHANGELOG.md is never
    touched.

Changes

  • plugin/skills/ase-code-review/SKILL.md, help.md: the new skill and its manual page
  • plugin/skills/ase-help-skill/catalog.md: entry under VERSION CONTROL
  • plugin/skills/ase-meta-workflow/workflow.txt: START -> ase-code-review -> END
  • pages/src/data/skills.ts: entry next to ase-meta-review
  • README.md, docs/usage-plugin.md: usage entries
  • AGENTS.md, pages/src/components/Section-Usage.astro: skill count 53 → 54

Not updated: docs/workflow.graffle and the SVG/PDF renderings derived from it, as they
are binary sources on your side.

Verification

Verified end-to-end in live Claude Code sessions (dev install). npm start lint passes for plugin (markdownlint + eslint) and pages
(astro check + eslint).

No CHANGELOG entry included on purpose.

🤖 Generated with Claude Code

…nges into commits

Groups all uncommitted hunks into themes, confirms the cut from one
table, stages one theme at a time into the plain Git index, explains it
in a boxed group card with per-file, line-cited evidence and an honest
verdict, and commits only on the user's explicit accept. A demanded
correction is implemented via ase-code-edit and the group re-presented.

Registers the skill in the help catalog, workflow graph, pages skill
list, README, usage documentation, and the skill counts.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant