feat(ase-code-review): add skill to review and curate uncommitted changes into commits - #84
Open
Brusdeylins wants to merge 1 commit into
Open
Brusdeylins wants to merge 1 commit into
Brusdeylins wants to merge 1 commit into
Conversation
…nges into commits Groups all uncommitted hunks into themes, confirms the cut from one table, stages one theme at a time into the plain Git index, explains it in a boxed group card with per-file, line-cited evidence and an honest verdict, and commits only on the user's explicit accept. A demanded correction is implemented via ase-code-edit and the group re-presented. Registers the skill in the help catalog, workflow graph, pages skill list, README, usage documentation, and the skill counts. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Brusdeylins
force-pushed
the
add-review-skill
branch
from
September 19, 2026 14:17
92a271e to
4dae415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a new skill
ase-code-reviewwhich reviews an accumulated pile of uncommittedchanges and curates them into clean, thematically coherent commits on the current
branch -- group by group, each committed only on the user's explicit accept.
It closes a gap between the existing version-control skills:
ase-meta-diffnarrateswhat changed,
ase-meta-reviewjudges an already staged diff,ase-meta-commitcrafts the message -- but nothing helps turn a large, mixed working tree into a
sequence of reviewed commits.
ase-code-reviewcurates and commits, and delegates tothose neighbours instead of duplicating them.
How it works
Grouping: every hunk of working tree, index, and untracked files is mapped to 3-5
themes (FEATURE, BUGFIX, REFACTOR, UPDATE, CLEANUP, IMPROVEMENT -- the taxonomy shared
with
ase-meta-commit/ase-meta-diff), ordered for comprehension (foundations first,no forward references). The user confirms the cut from one compact table; that
single dialog also carries the mode switches.
Modes:
HORIZONTAL(default) groups by topical proximity and runs no build;VERTICALcuts build-safe slices and gates every accept on a green build.TESTS-LAST(default) keeps test hunks in one final group;REVIEW-TESTSlets themjoin the code they cover.
Index-only staging: one group at a time is staged into the plain Git index -- no
work branch, no
git stash, no diff dumps. The staged set is verified against theplan, and the user reviews the actual lines in their own editor.
Group card: a boxed card per group with a rationale and, per file, a
plain-language before → after explanation, the touched symbols, and five evidence
lines (
DOMAIN,ARCH,CLEAN,PERF,TESTS). Each carries an honest status:✓only with a verbatimfile:linecitation,✗with the exposing case and thecheapest repair,
?when execution would be needed,–for n/a. A single✗flipsthe recommended answer from
ACCEPTtoCHANGE.Outcomes:
ACCEPTcommits viaase-meta-commit;CHANGEimplements the demandedcorrection via
ase-code-edit(mode derived from the wish) and re-presents the group;DISCUSS,SKIP,REGROUP, andCANCELnever discard working-tree content.Constraints: read-only tool allowlist for Git (
status,diff,show,log,grep,ls-files); dialogs follow the ASE custom-dialog convention with exactly onerecommended option; boxed output is pre-wrapped at 96 columns;
CHANGELOG.mdis nevertouched.
Changes
plugin/skills/ase-code-review/SKILL.md,help.md: the new skill and its manual pageplugin/skills/ase-help-skill/catalog.md: entry under VERSION CONTROLplugin/skills/ase-meta-workflow/workflow.txt:START -> ase-code-review -> ENDpages/src/data/skills.ts: entry next toase-meta-reviewREADME.md,docs/usage-plugin.md: usage entriesAGENTS.md,pages/src/components/Section-Usage.astro: skill count 53 → 54Not updated:
docs/workflow.graffleand the SVG/PDF renderings derived from it, as theyare binary sources on your side.
Verification
Verified end-to-end in live Claude Code sessions (dev install).
npm start lintpasses forplugin(markdownlint + eslint) andpages(astro check + eslint).
No CHANGELOG entry included on purpose.
🤖 Generated with Claude Code